Skip to content

chore(skore-hub-project/client): Add logging #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

chore(skore-hub-project/client): Add logging #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3937aab
chore(skore-hub-project/client): Add logging
auguste-probabl Sep 11, 2025
7dc0452
Add root logger
auguste-probabl Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions skore-hub-project/src/skore_hub_project/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Package that provides APIs to communicate between ``skore`` and ``skore hub``."""

import logging
from base64 import b64decode, b64encode
from contextlib import contextmanager

Expand All @@ -18,6 +19,9 @@
]


logging.basicConfig()
logger = logging.getLogger(__name__)

console = Console(
width=88,
theme=Theme(
Expand Down
12 changes: 11 additions & 1 deletion skore-hub-project/src/skore_hub_project/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import logging
from contextlib import suppress
from http import HTTPStatus
from os import environ
Expand All @@ -26,6 +27,8 @@

from ..authentication import token as Token

logger = logging.getLogger(__name__)


class Client(HTTPXClient):
"""
Expand Down Expand Up @@ -106,7 +109,14 @@ def request(self, *args, **kwargs) -> Response:
timeout = self.retry_backoff_factor * (2**retries)
retries += 1

sleep(min(timeout, self.retry_backoff_max))
sleep_duration = min(timeout, self.retry_backoff_max)

logger.warn(
"Request failed to reach server. "
f"Trying again in {sleep_duration} seconds."
)

sleep(sleep_duration)

# Raise extended exception with body message when available.
status_class = response.status_code // 100
Expand Down
Loading