Skip to content

fix(skore-hub-project): Use orjson to serialize payload, especially for nan #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix(skore-hub-project): Use orjson to serialize payload, especially for nan #2038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.10/scikit-learn-1.4/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ numpy==2.2.6
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.10/scikit-learn-1.7/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ numpy==2.2.6
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.11/scikit-learn-1.4/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.11/scikit-learn-1.7/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.12/scikit-learn-1.4/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.12/scikit-learn-1.7/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.13/scikit-learn-1.5/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.13/scikit-learn-1.6/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
2 changes: 2 additions & 0 deletions ci/requirements/skore-hub-project/python-3.13/scikit-learn-1.7/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ numpy==2.3.2
# skops
# skore
# skrub
orjson==3.11.3
# via skore-hub-project (skore-hub-project/pyproject.toml)
packaging==25.0
# via
# altair
Expand Down
1 change: 1 addition & 0 deletions skore-hub-project/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dependencies = [
"httpx",
"joblib",
"matplotlib",
"orjson",
"pydantic",
"rich",
"scikit-learn",
Expand Down
11 changes: 10 additions & 1 deletion skore-hub-project/src/skore_hub_project/project/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from typing import TYPE_CHECKING

import joblib
import orjson

from skore_hub_project.client.client import Client, HTTPStatusError, HUBClient
from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
Expand Down Expand Up @@ -178,9 +179,17 @@ def put(self, key: str, report: EstimatorReport | CrossValidationReport):

payload = Payload(project=self, key=key, report=report)
payload_dict = payload.model_dump()
payload_json_bytes = orjson.dumps(payload_dict, option=orjson.OPT_NON_STR_KEYS)

with HUBClient() as client:
client.post(url=url, json=payload_dict)
client.post(
url=url,
content=payload_json_bytes,
headers={
"Content-Length": str(len(payload_json_bytes)),
"Content-Type": "application/json",
},
)

@ensure_project_is_created
def get(self, urn: str) -> EstimatorReport | CrossValidationReport:
Expand Down
Loading