Skip to content

fix(skore-hub-project): Fix splitting strategy name when splitter doe… #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix(skore-hub-project): Fix splitting strategy name when splitter doe… #2048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions skore-hub-project/src/skore_hub_project/report/cross_validation_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import numpy as np
from pydantic import Field, computed_field
from sklearn.model_selection import BaseCrossValidator
from sklearn.model_selection._split import _CVIterableWrapper

from skore_hub_project.artefact import CrossValidationReportArtefact
Expand Down Expand Up @@ -160,12 +159,10 @@ def dataset_size(self) -> int:
@cached_property
def splitting_strategy_name(self) -> str:
"""The name of the splitting strategy used by the report."""
is_sklearn_splitter = isinstance(self.report.splitter, BaseCrossValidator)
is_iterable_splitter = isinstance(self.report.splitter, _CVIterableWrapper)
is_standard_strategy = is_sklearn_splitter and (not is_iterable_splitter)

return (
is_standard_strategy and self.report.splitter.__class__.__name__ or "custom"
is_iterable_splitter and "custom" or self.report.splitter.__class__.__name__
)

@computed_field # type: ignore[prop-decorator]
Expand Down
Loading