-
Notifications
You must be signed in to change notification settings - Fork 101
fix(skore): Don't rely on _repr_html_ to display the summary widget #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(skore): Don't rely on _repr_html_ to display the summary widget #2059
Conversation
|
Caution Some commits in the pull request are not signed, or GitHub is not able to verify the signature. |
auguste-probabl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
|
I see that your commits are not signed btw |
|
The two first ones are not but the third one should be, I created a GPG key after seeing the gh action warning. |
|
You can sign commits after making them, if you can force-push. |
|
This PR changes the representation of the Could you find a way to disable the representation of the widget in |
Fixes #2039
The colab button to convert a dataframe into an interactive table appears to call the dataframe's
_repr_html_, so when it is used on a summary (which inherits from the dataframe class), the widget would be displayed a second time as_repr_html_is called again.The proposed solution is to display the widget in
_repr_mimebundle_and override_repr_html_to return an empty string.