Skip to content

feat(skore-hub-project): Remove run_id #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

feat(skore-hub-project): Remove run_id #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions skore-hub-project/src/skore_hub_project/project/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

class Metadata(TypedDict): # noqa: D101
id: str
run_id: int
key: str
date: str
learner: str
Expand Down Expand Up @@ -225,7 +224,6 @@ def dto(response):

return {
"id": summary["urn"],
"run_id": -1, # FIXME: deprecated
"key": summary["key"],
"date": summary["created_at"],
"learner": summary["estimator_class_name"],
Expand Down
3 changes: 0 additions & 3 deletions skore-hub-project/tests/unit/project/test_project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ def test_reports_metadata(self, nowstr, respx_mock):
"roc_auc_mean": None,
"fit_time_mean": None,
"predict_time_mean": None,
"run_id": -1,
},
{
"id": "skore:report:estimator:<report_id_1>",
Expand All @@ -306,7 +305,6 @@ def test_reports_metadata(self, nowstr, respx_mock):
"roc_auc_mean": None,
"fit_time_mean": None,
"predict_time_mean": None,
"run_id": -1,
},
{
"id": "skore:report:cross-validation:<report_id_2>",
Expand All @@ -326,7 +324,6 @@ def test_reports_metadata(self, nowstr, respx_mock):
"roc_auc_mean": None,
"fit_time_mean": None,
"predict_time_mean": None,
"run_id": -1,
},
]

Expand Down
2 changes: 0 additions & 2 deletions skore/tests/unit/project/test_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def __init__(self, *reports):
def make_report_metadata(self, index, report):
return {
"id": index,
"run_id": None,
"key": None,
"date": None,
"learner": None,
Expand Down Expand Up @@ -131,7 +130,6 @@ def test_factory(
),
)
assert list(summary.columns) == [
"run_id",
"key",
"date",
"learner",
Expand Down