Skip to content

Conversation

@auguste-probabl
Copy link
Contributor

  • Display
╭──── Skore Hub ─────╮
│                    │
│ Already logged in! │
│                    │
╰────────────────────╯

if user is already logged in (i.e. if token is found at /tmp/skore.token), rather than showing nothing. A better fix would be to show a log of "found token at /tmp/skore.token") I guess; let me know what you think.

  • Display login URL in full, without line-wrapping, regardless of whether opening the browser succeeds. This way, the user can always fall back to copy-pasting the URL. Disabling line-wrapping is important because otherwise the URL is hard to copy-paste:
╭───────────────────────────────────── Skore HUB ──────────────────────────────────────╮
│                                                                                      │
│ Please visit this URL to log in:                                                     │
│ https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.com/oauth2/auth?response_type=code&cli │
│ ent_id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx&redirect_uri=http%3A%2F%2Flocalhost%3A80 │
│ 00%2Fidentity%2Foauth%2Fdevice%2Fcallback&scope=openid+profile+email+offline_access& │
│ state=xxxxx                                                                          │
│                                                                                      │
╰──────────────────────────────────────────────────────────────────────────────────────╯

@auguste-probabl auguste-probabl changed the title Push tvnvtnmpqvnn fix(skore-hub-project): Make skore-hub-login more user-friendly Oct 16, 2025
@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py22195%39
   protocol.py290100% 
skore-hub-project/src/skore_hub_project/artifact
   __init__.py00100% 
   artifact.py230100% 
   serializer.py260100% 
   upload.py36488%175, 177–178, 180
skore-hub-project/src/skore_hub_project/artifact/media
   __init__.py50100% 
   data.py240100% 
   feature_importance.py360100% 
   media.py70100% 
   model.py80100% 
   performance.py440100% 
skore-hub-project/src/skore_hub_project/artifact/pickle
   __init__.py20100% 
   pickle.py240100% 
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py210100% 
   logout.py50100% 
   token.py180100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   api.py470100% 
   client.py640100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py320100% 
   brier_score.py320100% 
   log_loss.py340100% 
   metric.py49197%23
   precision.py600100% 
   r2.py320100% 
   recall.py600100% 
   rmse.py340100% 
   roc_auc.py340100% 
   timing.py87495%51–52, 113–114
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py91396%187, 291, 319
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py63198%203
   estimator_report.py120100% 
   report.py510100% 
TOTAL11251498% 

Tests Skipped Failures Errors Time
134 0 💤 0 ❌ 0 🔥 1m 34s ⏱️

@thomass-dev thomass-dev added this pull request to the merge queue Oct 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2025
)

- Display
```
╭──── Skore Hub ─────╮
│                    │
│ Already logged in! │
│                    │
╰────────────────────╯
```
if user is already logged in (i.e. if token is found at
`/tmp/skore.token`), rather than showing nothing. A better fix would be
to show a log of "found token at /tmp/skore.token") I guess; let me know
what you think.
- Display login URL in full, without line-wrapping, regardless of
whether opening the browser succeeds. This way, the user can always fall
back to copy-pasting the URL. Disabling line-wrapping is important
because otherwise the URL is hard to copy-paste:
```
╭───────────────────────────────────── Skore HUB ──────────────────────────────────────╮
│                                                                                      │
│ Please visit this URL to log in:                                                     │
│ https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.com/oauth2/auth?response_type=code&cli │
│ ent_id=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx&redirect_uri=http%3A%2F%2Flocalhost%3A80 │
│ 00%2Fidentity%2Foauth%2Fdevice%2Fcallback&scope=openid+profile+email+offline_access& │
│ state=xxxxx                                                                          │
│                                                                                      │
╰──────────────────────────────────────────────────────────────────────────────────────╯
```
@thomass-dev thomass-dev removed this pull request from the merge queue due to a manual request Oct 16, 2025
@thomass-dev thomass-dev merged commit f21e859 into probabl-ai:main Oct 16, 2025
33 of 34 checks passed
@auguste-probabl auguste-probabl deleted the push-tvnvtnmpqvnn branch October 27, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants