Skip to content

chore(skore-hub-project): Remove pandas from transitive dependencies #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

chore(skore-hub-project): Remove pandas from transitive dependencies #2074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions skore-hub-project/src/skore_hub_project/artifact/media/feature_importance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from functools import reduce
from typing import ClassVar, Literal, cast

from pandas import DataFrame
from pydantic import Field

from skore_hub_project.artifact.media.media import Media
Expand Down Expand Up @@ -33,7 +32,7 @@ def content_to_upload(self) -> bytes | None: # noqa: D102
else function(data_source=self.data_source)
)

if not isinstance(result, DataFrame):
if hasattr(result, "frame"):
result = result.frame()

return orjson.dumps(
Expand Down
9 changes: 4 additions & 5 deletions skore-hub-project/src/skore_hub_project/metric/timing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from functools import cached_property
from typing import ClassVar, Literal

from pandas import DataFrame, Series
from pydantic import Field, computed_field

from skore_hub_project.protocol import CrossValidationReport, EstimatorReport
Expand Down Expand Up @@ -44,10 +43,10 @@ class FitTimeAggregate(Metric): # noqa: D101
@computed_field # type: ignore[prop-decorator]
@cached_property
def value(self) -> float | None: # noqa: D102
timings: DataFrame = self.report.metrics.timings(aggregate=self.aggregate)
timings = self.report.metrics.timings(aggregate=self.aggregate)

try:
fit_times: Series = timings.loc["Fit time (s)"]
fit_times = timings.loc["Fit time (s)"]
except KeyError:
return None

Expand Down Expand Up @@ -106,10 +105,10 @@ class PredictTimeAggregate(Metric): # noqa: D101
@computed_field # type: ignore[prop-decorator]
@cached_property
def value(self) -> float | None: # noqa: D102
timings: DataFrame = self.report.metrics.timings(aggregate=self.aggregate)
timings = self.report.metrics.timings(aggregate=self.aggregate)

try:
predict_times: Series = timings.loc[f"Predict time {self.data_source} (s)"]
predict_times = timings.loc[f"Predict time {self.data_source} (s)"]
except KeyError:
return None

Expand Down
3 changes: 1 addition & 2 deletions skore-hub-project/tests/unit/artifact/media/test_feature_importance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from functools import partialmethod

from pandas import DataFrame
from pydantic import ValidationError
from pytest import fixture, mark, param, raises
from skore_hub_project import Project
Expand All @@ -16,7 +15,7 @@
def serialize(result) -> bytes:
import orjson

if not isinstance(result, DataFrame):
if hasattr(result, "frame"):
result = result.frame()

return orjson.dumps(
Expand Down