Skip to content

Conversation

@auguste-probabl
Copy link
Contributor

@auguste-probabl auguste-probabl commented Oct 28, 2025

Co-authored-by: Thomas S [email protected]


Partially addresses https://github.com/probabl-ai/skore-hub/issues/812.

@thomass-dev thomass-dev force-pushed the skore-hub-project-put-feature-importance-on-demand branch from 1995d0c to 7847c26 Compare October 28, 2025 10:31
@thomass-dev thomass-dev changed the title fix(skore-hub-project): Only push feature importance if it is in the report cache fix(skore-hub-project): Only push permutations if they are computed Oct 28, 2025
@github-actions
Copy link
Contributor

Coverage

Coverage Report for skore-hub-project/
FileStmtsMissCoverMissing
skore-hub-project/src/skore_hub_project
   __init__.py22195%39
   protocol.py310100% 
skore-hub-project/src/skore_hub_project/artifact
   __init__.py00100% 
   artifact.py230100% 
   serializer.py260100% 
   upload.py36488%175, 177–178, 180
skore-hub-project/src/skore_hub_project/artifact/media
   __init__.py50100% 
   data.py220100% 
   feature_importance.py44197%50
   media.py100100% 
   model.py90100% 
   performance.py440100% 
skore-hub-project/src/skore_hub_project/artifact/pickle
   __init__.py20100% 
   pickle.py240100% 
skore-hub-project/src/skore_hub_project/authentication
   __init__.py00100% 
   login.py660100% 
   logout.py40100% 
   token.py240100% 
   uri.py180100% 
skore-hub-project/src/skore_hub_project/client
   __init__.py00100% 
   client.py600100% 
skore-hub-project/src/skore_hub_project/metric
   __init__.py100100% 
   accuracy.py350100% 
   brier_score.py350100% 
   log_loss.py350100% 
   metric.py49197%25
   precision.py610100% 
   r2.py350100% 
   recall.py630100% 
   rmse.py350100% 
   roc_auc.py350100% 
   timing.py90495%52–53, 115–116
skore-hub-project/src/skore_hub_project/project
   __init__.py00100% 
   project.py102397%204, 308, 338
skore-hub-project/src/skore_hub_project/report
   __init__.py30100% 
   cross_validation_report.py64198%204
   estimator_report.py120100% 
   report.py520100% 
TOTAL11861598% 

Tests Skipped Failures Errors Time
139 0 💤 0 ❌ 0 🔥 1m 10s ⏱️

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thomass-dev thomass-dev merged commit bc75515 into main Oct 28, 2025
37 checks passed
@thomass-dev thomass-dev deleted the skore-hub-project-put-feature-importance-on-demand branch October 28, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants