chore(skore): Identical ruff settings across packages #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomass-dev
requested changes
Oct 29, 2025
Collaborator
thomass-dev
left a comment
thomass-dev
left a comment
There was a problem hiding this comment.
Please rebase your PR.
I chose to remove the comments because anyone messing with ruff rules should be more or less familiar with the main rule sets. Additionally, the comment for `T` was slightly misleading: `T` stands not only for `T20` (flake8-print) but also `T10` (flake8-debugger).
DimitriPapadopoulos
force-pushed
the
ruff.lint.select
branch
from
07c888b to
05d1a27
Compare
thomass-dev
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistency between packages:
skore/skore-hub-project/pyproject.toml
Lines 85 to 86 in 67193cf
skore/skore-local-project/pyproject.toml
Lines 76 to 77 in 67193cf
skore/skore/pyproject.toml
Lines 137 to 142 in 67193cf
I chose to remove the comments because anyone messing with ruff rules should be more or less familiar with the main rule sets. Additionally, the comment for
Twas slightly misleading:Tstands not only forT20(flake8-print) but alsoT10(flake8-debugger).