Skip to content

Conversation

@MAVRICK-1
Copy link
Contributor

@MAVRICK-1 MAVRICK-1 commented Oct 29, 2025

  • Enhanced scoring parameter to accept dict[str, Scoring] where keys become metric names
  • Removed scoring_names parameter to simplify API
  • Updated both EstimatorReport and CrossValidationReport metrics accessors
  • Added comprehensive tests for new dict functionality
  • Updated existing tests to use new API
  • Maintained backward compatibility for list/single scoring

Closes #1984

@github-actions
Copy link
Contributor

Caution

Some commits in the pull request are not signed, or GitHub is not able to verify the signature.
Please sign all your commits; you can find more information here.
Please note that when you activate commit signing, you'll need to retroactively sign your previous commits.

…ove scoring_names

- Enhanced scoring parameter to accept dict[str, Scoring] where keys become metric names
- Removed scoring_names parameter to simplify API
- Updated both EstimatorReport and CrossValidationReport metrics accessors
- Added comprehensive tests for new dict functionality
- Updated existing tests to use new API
- Maintained backward compatibility for list/single scoring

Closes probabl-ai#1984
@MAVRICK-1 MAVRICK-1 force-pushed the enh/estimator-report-scoring-dict branch from 37fc7d2 to ae43cd4 Compare October 29, 2025 14:01
@auguste-probabl auguste-probabl changed the title enh(EstimatorReport.summarize): Allow passing scoring as dict and rem… feat!(skore): Allow passing scoring as dict to EstimatorReport Oct 29, 2025
@MAVRICK-1 MAVRICK-1 changed the title feat!(skore): Allow passing scoring as dict to EstimatorReport feat:(skore): Allow passing scoring as dict to EstimatorReport Oct 29, 2025
@MAVRICK-1 MAVRICK-1 marked this pull request as draft October 29, 2025 14:54
@MAVRICK-1 MAVRICK-1 changed the title feat:(skore): Allow passing scoring as dict to EstimatorReport feat(skore): Allow passing scoring as dict to EstimatorReport Oct 29, 2025
@auguste-probabl auguste-probabl changed the title feat(skore): Allow passing scoring as dict to EstimatorReport feat(skore)!: Allow passing scoring as dict to EstimatorReport Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Coverage

Coverage Report for skore/
FileStmtsMissCoverMissing
skore/src/skore
   __init__.py230100% 
   _config.py310100% 
   exceptions.py440%4, 15, 19, 23
skore/src/skore/_sklearn
   __init__.py60100% 
   _base.py1981492%45, 58, 127, 130, 183, 186–187, 189–192, 225, 228–229
   find_ml_task.py610100% 
   types.py27196%28
skore/src/skore/_sklearn/_comparison
   __init__.py70100% 
   feature_importance_accessor.py35294%88, 107
   metrics_accessor.py179398%167, 247, 1209
   report.py1070100% 
   utils.py540100% 
skore/src/skore/_sklearn/_cross_validation
   __init__.py90100% 
   data_accessor.py45393%134, 137, 140
   feature_importance_accessor.py240100% 
   metrics_accessor.py183199%242
   report.py135199%487
skore/src/skore/_sklearn/_estimator
   __init__.py90100% 
   data_accessor.py66198%82
   feature_importance_accessor.py168298%251–252
   metrics_accessor.py353598%285, 354, 358, 373, 408
   report.py165298%448–449
skore/src/skore/_sklearn/_plot
   __init__.py30100% 
   base.py98693%61–62, 224–226, 230
   utils.py770100% 
skore/src/skore/_sklearn/_plot/data
   __init__.py20100% 
   table_report.py185199%706
skore/src/skore/_sklearn/_plot/metrics
   __init__.py60100% 
   confusion_matrix.py70494%92, 100, 122, 230
   feature_importance_display.py672168%88, 121–122, 124, 142–146, 148–155, 158–160, 162
   metrics_summary_display.py80100% 
   precision_recall_curve.py281598%455, 555, 559, 619, 751
   prediction_error.py227597%179, 186, 422, 505, 705
   roc_curve.py294897%387, 510, 515, 616, 621, 625, 694, 834
skore/src/skore/_sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py580100% 
skore/src/skore/_sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py19194%83
   high_class_imbalance_warning.py200100% 
   random_state_unset_warning.py100100% 
   shuffle_true_warning.py90100% 
   stratify_is_set_warning.py100100% 
   time_based_column_warning.py210100% 
   train_test_split_warning.py30100% 
skore/src/skore/_utils
   __init__.py6266%8, 13
   _accessor.py90396%34, 146, 190
   _environment.py270100% 
   _fixes.py80100% 
   _index.py50100% 
   _logger.py22481%15–17, 19
   _measure_time.py100100% 
   _parallel.py38392%23, 33, 124
   _patch.py13561%21, 23–24, 35, 37
   _progress_bar.py460100% 
   _repr_html.py80100% 
   _show_versions.py380100% 
   _testing.py550100% 
skore/src/skore/project
   __init__.py20100% 
   project.py480100% 
   summary.py75198%120
   widget.py1870100% 
TOTAL404310897% 

Tests Skipped Failures Errors Time
1104 5 💤 0 ❌ 0 🔥 4m 26s ⏱️

@auguste-probabl auguste-probabl marked this pull request as ready for review November 5, 2025 17:03
@auguste-probabl auguste-probabl added this pull request to the merge queue Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

Documentation preview @ 9a7121a

Merged via the queue into probabl-ai:main with commit 0bb33bf Nov 5, 2025
32 checks passed
@MAVRICK-1
Copy link
Contributor Author

@auguste-probabl sorry , i really forgot about the pr thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api(skore): Allow passing scoring as a dict and remove scoring_names argument

2 participants