-
Notifications
You must be signed in to change notification settings - Fork 101
feat(skore)!: Allow passing scoring as dict to EstimatorReport
#2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auguste-probabl
merged 8 commits into
probabl-ai:main
from
MAVRICK-1:enh/estimator-report-scoring-dict
Nov 5, 2025
Merged
feat(skore)!: Allow passing scoring as dict to EstimatorReport
#2100
auguste-probabl
merged 8 commits into
probabl-ai:main
from
MAVRICK-1:enh/estimator-report-scoring-dict
Nov 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Some commits in the pull request are not signed, or GitHub is not able to verify the signature. |
…ove scoring_names - Enhanced scoring parameter to accept dict[str, Scoring] where keys become metric names - Removed scoring_names parameter to simplify API - Updated both EstimatorReport and CrossValidationReport metrics accessors - Added comprehensive tests for new dict functionality - Updated existing tests to use new API - Maintained backward compatibility for list/single scoring Closes probabl-ai#1984
37fc7d2 to
ae43cd4
Compare
scoring as dict to EstimatorReport
scoring as dict to EstimatorReportscoring as dict to EstimatorReport
scoring as dict to EstimatorReportscoring as dict to EstimatorReport
scoring as dict to EstimatorReportscoring as dict to EstimatorReport
There was a bug that ignored `scoring_names` in the first place anyway.
Contributor
auguste-probabl
approved these changes
Nov 5, 2025
Contributor
Contributor
Author
|
@auguste-probabl sorry , i really forgot about the pr thanx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1984