Skip to content

fix(skore-hub-project/tests): Make tests independent of the version of joblib #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix(skore-hub-project/tests): Make tests independent of the version of joblib #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion skore-hub-project/tests/unit/report/test_cross_validation_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import numpy as np
from joblib import hash
from pydantic import ValidationError
from pytest import fixture, mark, raises
from sklearn.datasets import make_classification, make_regression
Expand Down Expand Up @@ -268,7 +269,7 @@ def test_model_dump(self, small_cv_binary_classification, payload):
assert payload_dict == {
"key": "<key>",
"estimator_class_name": "RandomForestClassifier",
"dataset_fingerprint": "cffe9686d06a56d0afe0c3a29d3ac6bf",
"dataset_fingerprint": hash(small_cv_binary_classification.y),
"ml_task": "binary-classification",
"groups": None,
"pickle": {
Expand Down
3 changes: 2 additions & 1 deletion skore-hub-project/tests/unit/report/test_estimator_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from joblib import hash
from pydantic import ValidationError
from pytest import fixture, mark, raises
from skore import CrossValidationReport, EstimatorReport
Expand Down Expand Up @@ -150,7 +151,7 @@ def test_model_dump(self, binary_classification, payload):
assert payload_dict == {
"key": "<key>",
"estimator_class_name": "RandomForestClassifier",
"dataset_fingerprint": "35806b458ab1a6d0c675fd226d7fc34a",
"dataset_fingerprint": hash(binary_classification.y_test),
"ml_task": "binary-classification",
"pickle": {
"checksum": checksum,
Expand Down