feat(skore,skore-hub-project): Fix compatibility for Jupyterlite#2821
Closed
thomass-dev wants to merge 7 commits intomainfrom
Closed
feat(skore,skore-hub-project): Fix compatibility for Jupyterlite#2821thomass-dev wants to merge 7 commits intomainfrom
thomass-dev wants to merge 7 commits intomainfrom
Conversation
thomass-dev
changed the title
Contributor
glemaitre
reviewed
Apr 24, 2026
| plt.switch_backend(original) | ||
|
|
||
|
|
||
| def threadable() -> bool: |
Member
There was a problem hiding this comment.
I'm wondering that instead to make fail a thread to check the platform with something like
def _can_start_thread() -> bool:
if sys.platform == "emscripten":
return sys._emscripten_info.pthreads
return platform.machine() not in ("wasm32", "wasm64")
thomass-dev
commented
Apr 28, 2026
Collaborator
Author
There was a problem hiding this comment.
This change should be superseded by Textualize/rich#4104.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
To be splitted in several PR: