Skip to content

Correct command from 'cargo binstall' to 'cargo install'#214

Closed
5731la wants to merge 1 commit intoprobe-rs:masterfrom
5731la:patch-1
Closed

Correct command from 'cargo binstall' to 'cargo install'#214
5731la wants to merge 1 commit intoprobe-rs:masterfrom
5731la:patch-1

Conversation

@5731la
Copy link
Copy Markdown

@5731la 5731la commented Dec 20, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 20, 2025 18:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to correct an installation command in the documentation by changing cargo binstall to cargo install. However, this creates an inconsistency: the command is located under a section specifically titled "cargo binstall", while cargo install is a different tool already documented in a separate section below.

Key Changes

  • Changes the installation command from cargo binstall probe-rs-tools to cargo install probe-rs-tools within the cargo binstall section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


```bash
cargo binstall probe-rs-tools
cargo install probe-rs-tools
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates an inconsistency. The section header indicates this is for "cargo binstall" (a tool that downloads pre-compiled binaries), but the command has been changed to "cargo install" (which builds from source).

Since there is already a separate section below titled "Installing from source (cargo install)" that documents the cargo install method, this section should use the correct command for cargo binstall. The original command "cargo binstall probe-rs-tools" appears to be correct for this section.

If the intention is to remove the cargo binstall section entirely, then the section header and this code block should be removed, not just the command changed.

Suggested change
cargo install probe-rs-tools
cargo binstall probe-rs-tools

Copilot uses AI. Check for mistakes.
@5731la
Copy link
Copy Markdown
Author

5731la commented Dec 20, 2025

Ah, not a typo, I just skimmed a little too hard.

@5731la 5731la closed this Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants