Correct command from 'cargo binstall' to 'cargo install'#214
Correct command from 'cargo binstall' to 'cargo install'#2145731la wants to merge 1 commit intoprobe-rs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to correct an installation command in the documentation by changing cargo binstall to cargo install. However, this creates an inconsistency: the command is located under a section specifically titled "cargo binstall", while cargo install is a different tool already documented in a separate section below.
Key Changes
- Changes the installation command from
cargo binstall probe-rs-toolstocargo install probe-rs-toolswithin the cargo binstall section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```bash | ||
| cargo binstall probe-rs-tools | ||
| cargo install probe-rs-tools |
There was a problem hiding this comment.
This change creates an inconsistency. The section header indicates this is for "cargo binstall" (a tool that downloads pre-compiled binaries), but the command has been changed to "cargo install" (which builds from source).
Since there is already a separate section below titled "Installing from source (cargo install)" that documents the cargo install method, this section should use the correct command for cargo binstall. The original command "cargo binstall probe-rs-tools" appears to be correct for this section.
If the intention is to remove the cargo binstall section entirely, then the section header and this code block should be removed, not just the command changed.
| cargo install probe-rs-tools | |
| cargo binstall probe-rs-tools |
|
Ah, not a typo, I just skimmed a little too hard. |
No description provided.