Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for Issue #820 #822

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

diyelectromusic
Copy link
Collaborator

Potential fix for issue #820 where saving default performance always overwrites the first performance in the current bank, but should act on bank 0, performance 0.

Note: untested at this time by me. If someone fancies trying it - please do!

Kevin

…e always overwrites the first performance in the current bank, but should act on bank 0, performance 0.
Copy link

Build for testing:
MiniDexed_2025-03-10-e3e3607
Use at your own risk.

@Banana71
Copy link

Hey @diyelectromusic Kevin, thank you very much, you were successful. On my setup "Save as default" now works great. ❤️

@probonopd
Copy link
Owner

@Banana71 if you could test this I'd appreciate it - I'm away from my gear for a couple of days. Thanks!

@Banana71
Copy link

One more note: the miniDexed switches to the "default" bank after "save as default", which is logical.

@diyelectromusic
Copy link
Collaborator Author

It would be more complicated to do otherwise as MiniDexed has a pretty short-term memory when it comes to performance banks - it basically has a current directory concept which is managed within the performance code, but the choice of saving as default or not is within the synth code (which doesn't know anything about the directories).

I could probably do something like:

  • Remember the current bank/performance
  • Select bank 0 and save as performance 0
  • Restore previous bank/performance

That would probably work, but yes, I think leaving the system set to what you've just saved does largely seem right to me.

Kevin

@probonopd probonopd merged commit bba0c93 into probonopd:main Mar 10, 2025
1 check passed
@probonopd
Copy link
Owner

Thanks @diyelectromusic for fixing this so swiftly and thanks @Banana71 for bringing this to our attention and for testing it.

@diyelectromusic diyelectromusic deleted the Issue820Fix branch March 10, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants