Cleanup reverb state on reverb enable

[soyersoyer]

Since doReverb was not called after reverb was turned off, so the cleanup was missed.

Call the cleanup explicitly when enabling reverb.

The cleanup() resets all values ​​associated with the previous run to zero.

This change also removes the unnecessary bypass variable, as doReverb is only called when it is enabled (m_nParameter[ParameterReverbEnable]).

[soyersoyer]

This needs some testing. Is this really useful?
Not all the noise I don't like about the performance change has gone away.

[github-actions]

Build for testing:
MiniDexed_1111_2025-04-23-ee409ea_32bit
MiniDexed_1111_2025-04-23-ee409ea_64bit
Use at your own risk.

[probonopd]

It seems to abruptly stop any still-running reverb tail when a new performance is loaded.

I think it gives a small "click" artefact due to the abrupt cutoff. Maybe we could use a very short fade out instead to avoid that?

[probonopd]

It also seems to cut off any still-playing notes. Is that intended? I don't think e.g., the Montage does it that way ;-)

[github-actions]

Build for testing:
MiniDexed_1112_2025-04-23-a5d4b79_32bit
MiniDexed_1112_2025-04-23-a5d4b79_64bit
Use at your own risk.

[soyersoyer]

It also seems to cut off any still-playing notes. Is that intended? I don't think e.g., the Montage does it that way ;-)

That's really not good then.

I saw on some big brand synths that you can set whether the existing sounds should continue to play when changing performance.

The still playing notes will stop when changing performance even without this commit. So that's intended:)

The click is not intended. But it's there even without the commit.

But it's less annoying because there's a little reverb on top :)