feat!: configure IconPainter via constructor options #3419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove IconPainterProvider singleton. Users must now pass custom
IconPainter through renderer options in BpmnVisualization constructor.
BREAKING CHANGE: IconPainterProvider removed. Use renderer.iconPainter option instead.
Before:
IconPainterProvider.set(new CustomIconPainter());
new BpmnVisualization({ container: 'bpmn-container' });
After:
new BpmnVisualization({
container: 'bpmn-container',
renderer: { iconPainter: new CustomIconPainter() }
});
Changes:
- Add iconPainter property to RendererOptions with JSDoc
- Thread iconPainter: BpmnVisualization → GraphConfigurator → BpmnGraph → BpmnCellRenderer
- Remove IconPainterProvider class and exports
- Add integration test verifying custom IconPainter usage
- Add test fixture: simple-start-userTask-end.bpmn
- Use module-level pendingIconPainter variable to work around mxGraph factory method pattern
tbouffard
added
enhancement
|
♻️ PR Preview 9fcee53 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 9fcee53 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
not needed in BpmnGraph, tsc pass without it
tbouffard
commented
Nov 26, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove IconPainterProvider singleton. Users must now pass custom IconPainter through renderer options in BpmnVisualization constructor.
BREAKING CHANGE:
IconPainterProviderremoved. Use therenderer.iconPainteroption instead.Notes
Before:
It used of a global configuration, shared by all BpmnVisualization instances.
After:
It uses a local configuration, specific to the specific BpmnVisualization instance.
Changes:
Screenshots
Accessible by running the dev server locally http://localhost:10001/dev/public/index.html?url=/test/fixtures/bpmn/bpmn-rendering/tasks.bpmn&renderer.iconPainter.use.custom=true
Remaining tasks