Convert Editor to functional, splits off CodeMirror code into its own file #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-4246ac625c |
|
Thanks so much for your work on this! After doing some manual testing, I think this mostly felt good besides an issue with unsaved changes—I attached some videos below to help visualize it! In the current setup, if I have unsaved changes, the changes would remain. editor_ver.movHere, I think I'm seeing that the unsaved changes disappear on Autosave. PR_ver.movBesides this, I feel like everything else seems to work well for me! |
khanniie
force-pushed
the
connie-editor-conversion-splitoff-codemirror
branch
from
5b7cc8c to
76a8c97
Compare
khanniie
force-pushed
the
connie-editor-conversion-splitoff-codemirror
branch
from
1e8e8ce to
6d7ef6d
Compare
I'm fairly certain that we can remove ```
if (!prevProps?.unsavedChanges) {
setTimeout(() => setUnsavedChanges(false), 400);
}
```
I looked at the git blame and it looks like the intention was to stop setting unsavedchanges to false when the files switched, but i think the solve that was implemented 9 years ago did something like "if c == false, c = false" and we should be able to safely remove it instead.
reference commit: 77e2f5b
khanniie
changed the title
raclim
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of larger CodeMirror v5 -> v6 conversion. This converts the Editor component from class-based to functional style.
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123