-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed entire Bengali translation that is accessible to native speakers #3412
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Thanks for your work on this! We ideally want to keep changes in each pull request isolated to address solely just the issues. Since this issue focuses on translations, would you be able to remove the changes to the Since the changes to @dipamsen, I saw that you gave a thumbs up—would you be able to verify these translations? I'm sorry if that's not the case and I misinterpreted that! |
I've updated the package files that I previously changed for personal testing and forgot to remove while pushing the final commits. I appreciate reviewing the translation with other native speakers, though it's likely that 99% of natives will prefer the updated version. |
Thanks for the update on this! I removed the extra changes on
I understand, this is just a precedent that we ideally want to keep when merging in larger translations for our projects! Ideally, we want to make sure that they're double checked to maintain consistency and support a more collaborative review process. |
@raclim I am technically a native speaker, but not that fluent. I have skimmed through them, the changes make sense to me. Will go through all of them once and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments on few of the changes (and also some translations which haven't been changed). Though let me be clear that I am in no way a fluent speaker and I do not consume content on the internet in Bengali, so a lot of my suggestions may be incorrect, let me know wherever this is the case.
… branch with the latest corrections from upstream.
Fixes #3411
Changes:
Refined Bangla translations to enhance clarity and accessibility for native speakers. Simplified complex phrases and adjusted terminology to align with common usage while maintaining accuracy.
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #3411