Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed entire Bengali translation that is accessible to native speakers #3412

Merged
merged 10 commits into from
Mar 27, 2025

Conversation

Protik49
Copy link
Contributor

Fixes #3411

Changes:
Refined Bangla translations to enhance clarity and accessibility for native speakers. Simplified complex phrases and adjusted terminology to align with common usage while maintaining accuracy.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3411

Copy link

welcome bot commented Mar 21, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Mar 25, 2025

Thanks for your work on this!

We ideally want to keep changes in each pull request isolated to address solely just the issues. Since this issue focuses on translations, would you be able to remove the changes to the package.json and package-lock.json files?

Since the changes to translations/locales/be/translations.json are a bit more extensive and I'm not familiar with Bengali, I think it might be helpful to have another native speaker take a quick look at it as well!

@dipamsen, I saw that you gave a thumbs up—would you be able to verify these translations? I'm sorry if that's not the case and I misinterpreted that!

@Protik49
Copy link
Contributor Author

I've updated the package files that I previously changed for personal testing and forgot to remove while pushing the final commits.

I appreciate reviewing the translation with other native speakers, though it's likely that 99% of natives will prefer the updated version.

@raclim
Copy link
Collaborator

raclim commented Mar 25, 2025

Thanks for the update on this! I removed the extra changes on package-lock.json, and added in an extra note on the remaining changes needed for package.json.

I appreciate reviewing the translation with other native speakers, though it's likely that 99% of natives will prefer the updated version.

I understand, this is just a precedent that we ideally want to keep when merging in larger translations for our projects! Ideally, we want to make sure that they're double checked to maintain consistency and support a more collaborative review process.

@dipamsen
Copy link
Contributor

@raclim I am technically a native speaker, but not that fluent. I have skimmed through them, the changes make sense to me. Will go through all of them once and review.

Copy link
Contributor

@dipamsen dipamsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments on few of the changes (and also some translations which haven't been changed). Though let me be clear that I am in no way a fluent speaker and I do not consume content on the internet in Bengali, so a lot of my suggestions may be incorrect, let me know wherever this is the case.

@Protik49
Copy link
Contributor Author

hey, @raclim

I have so far resolved the issues identified by @dipamsen

@raclim
Copy link
Collaborator

raclim commented Mar 27, 2025

Thanks for the update @Protik49 and thanks so much @dipamsen for taking a shot at combing through this PR! This overall looks good to me!

@raclim raclim merged commit 24e4b59 into processing:develop Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Bengali Translation isn't accessible to Native Speakers
3 participants