Skip to content

Detailed example attribution #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ksen0
Copy link
Member

@ksen0 ksen0 commented May 13, 2025

Addresses #415 - work in progress. Remains to be done:

  • Support for cases where pre-2023 attribution is also collective e.g., Shape primitives
  • Support for cases where there is no link for author (not sure if case exists)
  • Once done on main, will need to be cherrypicked to 2.0 as well
  • Ensure all people mentioned in any part of attribution is on all-contriutors in p5.js README in both main and dev-2.0 branches and include "example" emoji

Before

The license is at the bottom of the page, and attribution (inspired by and maintained by) is split.

Screenshot 2025-05-13 at 12 21 45

(Then there is the sketch and the code - viewer has to scroll all the way down)

Screenshot 2025-05-13 at 12 21 51

After

Considering showing the attribution more clearly. "p5.js Contributors" also points to all-contributors list in p5.js repo README, rather than the People page.

image

@ksen0 ksen0 changed the title Initial format for detailed example attribution Detailed example attribution May 13, 2025
@ksen0 ksen0 moved this to In Progress in p5.js Documentation May 13, 2025
@calebfoss
Copy link
Contributor

@ksen0 This looks great! I really appreciate the thoughtfulness of how you put this together.

One tiny tweak: it occurred to me that since the code was copied over to this repo in 2024, it should be "2024 onwards" rather than 2023.

This certainly does not need to be in this PR, but something to consider for the future: I think it would be helpful for readers to have some visual design distinction between the description and attribution. I'm picturing the ways that text publications design attribution information in articles. Italics is a common convention but may look awkward with this much text. Maybe just a slightly different background color?

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants