Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to help get dev-2.0 branch running for other contributors #7215

Merged
merged 7 commits into from
Sep 7, 2024

Conversation

lukeplowden
Copy link

@lukeplowden lukeplowden commented Sep 4, 2024

Changes:

PR Checklist

  • npm run lint passes

@davepagurek davepagurek mentioned this pull request Sep 4, 2024
Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .gitignore and utils/convert.js changes are likely redundant with the merge of #7203 so they may not be needed anymore. The p5.Color.js one I'm not sure if those two values are being used somewhere still though? The API can change here so not necessarily need to retain these if they are no longer being used. (Edit: looks like its being used in WebGL, may need to review at a later point then)

The empty example folder I'm not sure it needs to have the script change to the rollup one just yet. If the idea is to have a dev environment going, npm run dev will use the one in preview/ although it is using module instance mode. I can set up one for the bundled global mode if that is the use case here.

@lukeplowden
Copy link
Author

Thanks that all makes sense. I see your edit and yes they're still used in WebGL, the idea was just to put these temporary getters in now so WebGL can still be worked on in other areas. But also happy to just leave this as a local fix.

Dev environment was the use case so you can close this if you'd like

@davepagurek
Copy link
Contributor

davepagurek commented Sep 5, 2024

Right, I think the color changes are things we can take out once we do a bigger refactor of the webgl module, but this unblocks development for now.

As an aside, I think it's something we may want to include in our 1.x compatibility layer -- I've seen people accessing the color levels/array properties as a quick way to convert colors into shader uniforms. Maybe I should make an issue to start keeping track of those things? (It might also be worth giving those a "real" API with a better name, like toNormalizedRGB() or something, since passing a color into a shader isn't too uncommon.)

Edit: added #7230

@davepagurek davepagurek merged commit 920ca49 into processing:dev-2.0 Sep 7, 2024
1 of 2 checks passed
@limzykenneth limzykenneth linked an issue Sep 12, 2024 that may be closed by this pull request
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 RFC Proposal]: Build and test system update
3 participants