Skip to content

Fix memory leak on loadImage failure #8958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksen0 merged 2 commits into from
Jun 25, 2026
+22 −1
Merged

Fix memory leak on loadImage failure #8958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd946bd
fix: revoke all object URLs created by loadImage
gfrancine Jun 25, 2026
df78f8f
Merge branch 'main' of github.com:gfrancine/p5.js into main
gfrancine Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/image/loading_displaying.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,11 @@ function loadingDisplaying(p5, fn){
const blob = new Blob([data], { type: contentType });
const url = URL.createObjectURL(blob);

img.onerror = e => reject(e);
img.onerror = e => {
URL.revokeObjectURL(url);
reject(e);
};

img.onload = () => {
URL.revokeObjectURL(url);
resolve(img);
Expand Down
17 changes: 17 additions & 0 deletions test/unit/image/loading.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,23 @@ suite('loading images', function() {
assert.deepEqual(img.get(0, 0), GREEN);
assert.deepEqual(img.get(47, 47), GREEN);
});

test('revokes any object URLs created during loading', async () => {
const createSpy = vi.spyOn(URL, 'createObjectURL');
const revokeSpy = vi.spyOn(URL, 'revokeObjectURL');

// successful load
await mockP5Prototype.loadImage(svgImage);
expect(revokeSpy).toHaveBeenCalledTimes(createSpy.mock.calls.length);

// errored load
const INVALID_PATH = '';
try { await mockP5Prototype.loadImage(INVALID_PATH); } catch {}
expect(revokeSpy).toHaveBeenCalledTimes(createSpy.mock.calls.length);

createSpy.mockRestore();
revokeSpy.mockRestore();
});
});

suite.todo('displaying images', function() {
Expand Down
Loading