Retry Failed Job

[ticosax]

This is an action intended to be manually invoked that put the failed job's state back to todo, while keeping the events history.

Only integrated within django (for now)
It's an Early submission (draft) for the purpose of getting feedback the maintainers. I would like to get confirmation that's something they'd like to consider, assuming I'll push it through with tests and updated documentation.
only Tested manually on my machine as it is.

Closes N/A

Successful PR Checklist:

• Tests
  • (not applicable?)
• Documentation
  • (not applicable?)

PR label(s):

• PR type: breaking 💥 Contains breaking changes
• PR type: feature ⭐️ Contains new features
• PR type: bugfix 🕵️ Contains bug fix
• PR type: miscellaneous 👾 Contains misc changes
• PR type: dependencies 🤖 Contains only dependencies updates
• PR type: documentation 📚 Contains documentation updates

[ewjoachim]

Hello!

I like the idea and large parts of the work already done.
I'm not sure I think a retried status is the best though. We had issues when we introduced a aborting state, which we had to undo. I think a job can be both retried AND todo, or doing, or suceeded or failed. If we want to capture that, it would rather be, I think, an event in the events table (capturing the fact a same job might be retried multiple times).

I like the idea of Django admin actions. but this immediately bears the idea of also aborting a task through the admin, though that might be for a later PR.

[ticosax]

Hi, thanks for your feedback.
I'm not sure I completely understand your recommendations though :)

I'm not sure I think a retried status is the best though.

I agree I haven't introduced one.

If we want to capture that, it would rather be, I think, an event in the events table

Exactly, we are in agreement. and the PR does that already ...

Am I hallucinating or you reviewed it a bit too quickly :)

Nevertheless, I will add some tests it will make feature clearer on how it's supposed to work, and maybe it will reveal my hallucinations.
Stay tuned

[ticosax]

In addition to django admin, do you see a need to expose this feature on the cli ?
Where else could it be useful ?

[ewjoachim]

Hm, maybe I have, I'll take some time time and reread through, apologies.

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
procrastinate
manager.py					522-523
testing.py
worker.py
Project Total

This report was generated by python-coverage-comment-action