feat: add timeout configuration and improve SMTP authentication error handling #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthentication - Added configurable timeout option to SmtpConfig interface - Implemented timeout handling for SMTP commands and connections - Enhanced authentication error messages with specific failure reasons - Added cleanup function to properly remove event listeners - Improved error handling for OAuth2, CRAM-MD5, LOGIN, and PLAIN auth methods - Added tests for authentication timeout scenarios
commit: |
Contributor
Author
@calebeaires Could you try this and report if this solves your problem? |
|
👍🏼 totally worked! can't wait to the pull request! |
Owner
|
@unitythemaker If you fix the lint errors, I can merge. Thank you for your contribution. |
|
Lint errors are only complaining about a line of code inside I would be glad to see this feature working as soon as possible @unitythemaker |
Contributor
Author
|
@productdevbook lint error is now fixed. |
Lowered the SMTP authentication timeout from 5s to 2s and reduced overall test timeouts to speed up test execution and improve reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19
Changes
timeoutproperty toSmtpConfiginterface for configurable connection/command timeoutssendSmtpCommandfunction with proper cleanupTest Plan