Skip to content

Conversation

@productdevbook
Copy link
Owner

  • Updated port assignment logic to handle undefined values correctly.
  • Refactored SMTP response parsing to better handle multi-line responses.
  • Improved DKIM signing by canonicalizing headers and body, ensuring correct header order.
  • Added checks for expected SMTP response codes.
  • Enhanced error handling during DKIM signing.
  • Adjusted the way additional headers are inserted into the MIME message.

test: skip mailCrab integration tests in non-GitHub Actions environments

…igning process

- Updated port assignment logic to handle undefined values correctly.
- Refactored SMTP response parsing to better handle multi-line responses.
- Improved DKIM signing by canonicalizing headers and body, ensuring correct header order.
- Added checks for expected SMTP response codes.
- Enhanced error handling during DKIM signing.
- Adjusted the way additional headers are inserted into the MIME message.

test: skip mailCrab integration tests in non-GitHub Actions environments
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitest/​coverage-v8@​3.1.1 ⏵ 3.1.29910070 +199100
Updatedvitest@​3.1.1 ⏵ 3.1.2971007796100
Updated@​types/​node@​22.14.1 ⏵ 22.15.3100 +110080 +196100
Updatedeslint@​9.24.0 ⏵ 9.26.09710010096100

View full report

@github-actions
Copy link

github-actions bot commented May 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 65.36% 1242 / 1900
🔵 Statements 65.36% 1242 / 1900
🔵 Functions 83.56% 61 / 73
🔵 Branches 64.09% 216 / 337
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/providers/smtp/provider.ts 40.93% 42.25% 56.25% 40.93% 60-61, 114-116, 136-140, 144-163, 169-173, 181-182, 187, 198-201, 204-206, 214-249, 256-278, 288-294, 301-304, 317-321, 323-324, 330-334, 337-338, 342-348, 353-371, 376-392, 397-406, 413-462, 485-486, 517-518, 526-528, 550-551, 568-578, 580-589, 607-608, 615-621, 625-631, 653-664, 668-684, 688-689, 693-698, 702-713, 717-735, 739-745, 749-750, 772-782, 784-793, 800-856, 863-883
Generated in workflow #37 for commit 7e294d5 by the Vitest Coverage Report Action

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/productdevbook/unemail@9

commit: 7e294d5

@productdevbook productdevbook merged commit 1e074b7 into main May 3, 2025
6 checks passed
@productdevbook productdevbook deleted the obuild branch May 3, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants