Open
Conversation
It's not guaranteed that `log_database_get_limits_info()` returns a non-NULL value or that `timestamp` is non-NULL. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
jubalh
reviewed
Mar 12, 2026
It's not guaranteed that `log_database_get_limits_info()` returns a non-NULL value or that `timestamp` is non-NULL. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Instead of flushing the OMEMO store to disk after each operation, do it only once after all recipients are processed. A user reported a long delay between hitting enter on the keyboard and the message being sent on the wire in an OMEMO-enabled group chat. This patch hopefully improves this situation. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
In the process of trying to bring down the time of sending an OMEMO encrypted message I noticed that a lot of time was spent in generating the random key and IV (~0.54s on my machine). By changing this to a single call to `gcry_random_bytes_secure()` I have been able to slash the time by 50% to ~0.27s. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into an issue reported in the profanity MUC I created this set of patches.
Please check commit messages for details.