Add GETDEL command support#1123
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Contributor
Author
There was a problem hiding this comment.
Pull request overview
Adds support for the Redis GETDEL command by extending the Getter algebra with a getDel method, implementing it in BaseRedis using Lettuce's getdel, and adding an integration test that covers missing-key, existing-key, and post-call deletion semantics.
Changes:
- Add
getDelmethod to theGetteralgebra trait. - Implement
getDelinBaseRedisvia Lettuce'sgetdel. - Extend
stringsScenariointegration test with assertions forgetDelbehavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/effects/src/main/scala/dev/profunktor/redis4cats/algebra/strings.scala | Adds getDel to the Getter algebra. |
| modules/effects/src/main/scala/dev/profunktor/redis4cats/redis.scala | Implements getDel in BaseRedis using Lettuce's getdel. |
| modules/tests/src/test/scala/dev/profunktor/redis4cats/TestScenarios.scala | Adds integration test coverage for missing key, existing key, and post-delete state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yisraelU
approved these changes
May 14, 2026
Collaborator
|
looks good. ty |
Contributor
Author
Thank you for merging and approval! |
Collaborator
|
@dpevunov-cp we publish snapshots upon merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDelto theGetteralgebra and implements it inBaseRedisvia Lettuce'sgetdel.TestScenarios.stringsScenariocovering missing key, existing key, and post-call deletion.Example
Test plan
sbt tests/Test/compilesbt scalafmtCheckAllstringsScenariopasses against a live Redis🤖 Generated with Claude Code