Skip to content

Patch dependency vulnerabilities across all manifests#173

Merged
denbec merged 4 commits into
mainfrom
denbec/security-fixes
May 6, 2026
Merged

Patch dependency vulnerabilities across all manifests#173
denbec merged 4 commits into
mainfrom
denbec/security-fixes

Conversation

@denbec

@denbec denbec commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • nuxt-app: 36 → 0 vulnerabilities. npm audit fix for transitive deps, nodemailer bumped 7 → 8 (only stable createTransport/sendMail are used), and a minimatch ^9.0.7 override clears the last @typescript-eslint advisories.
  • directus-cms: 55 → 22. Overrides force patched versions of AWS SDK (eliminates the critical fast-xml-parser advisory), tar, uuid, and several deep transitives. Remaining 22 are bundled inside Directus core (axios, express, path-to-regexp, body-parser, qs…) and need an upstream Directus release to fix safely.
  • extension bundle: 14 → 4. Direct axios bumped to ^1.16.0 plus a "$axios" override to dedupe the nested copy in @directus/composables. Remaining 4 are in @directus/themes / @unhead/vue dragged in by extensions-sdk and need upstream.

Test plan

  • npm test — extension bundle: 40/40 pass
  • npm run build — extension bundle builds cleanly with the new lockfile
  • Boot Directus locally and smoke-test admin UI + S3 storage if used
  • Smoke-test nuxt-app email flow (server/utils/sendEmail.ts) for the nodemailer 7→8 bump

🤖 Generated with Claude Code

denbec and others added 3 commits May 6, 2026 08:50
Runs npm audit fix to bump transitive deps (vite, h3, koa, dompurify,
lodash, picomatch, axios, etc.) within their semver ranges. Bumps
nodemailer from ^7.0.13 to ^8.0.7 — the codebase only uses the stable
createTransport/sendMail surface, which is unchanged in v8. Adds a
minimatch override to force ^9.0.7, eliminating the last remaining
ReDoS advisories that propagate through @typescript-eslint via
@nuxt/eslint-config. Drops nuxt-app vulnerability count from 36 to 0.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds package.json overrides to force patched versions of deps that
Directus core pulls in but doesn't yet ship updated:

- AWS SDK packages bumped to latest (eliminates fast-xml-parser
  critical CVE pulled in via the older S3 driver)
- fast-xml-parser, tar, uuid forced to patched versions to address
  high-severity CVEs (path traversal, ReDoS, missing buffer bounds)
- cacache, make-fetch-happen, node-gyp, http-proxy-agent,
  retry-request, teeny-request, @tootallnate/once bumped to patched
  versions

Drops directus-cms vulnerability count from 55 to 22. Remaining 22 are
bundled deep inside Directus core (axios, express, path-to-regexp,
body-parser, qs, etc.) and require upstream Directus releases — they
cannot be safely overridden without risking Directus runtime breakage.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Bumps the direct axios devDep from ^1.7.2 to ^1.16.0 (covers prototype
pollution and CRLF injection advisories) and adds a "$axios" override
so the nested copy pulled in via @directus/composables resolves to the
same patched version. Regenerating the lockfile picks up patched
transitive deps for handlebars, minimatch, picomatch, brace-expansion,
flatted, js-yaml, and ajv.

Drops the bundle's vulnerability count from 14 to 4. Remaining 4 are
in @directus/themes / @unhead/vue, which are dragged in by the
extensions-sdk and need an upstream Directus release to fix. Tests
(40 passing) and bundle build verified.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel

vercel Bot commented May 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
programmierbar-website Ready Ready Preview, Comment May 6, 2026 7:19am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 823ac6f7b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread directus-cms/package.json
Adds an "axios": "^1.16.0" override so the nested copy that
@directus/update-check pins (axios@1.13.5) is replaced with the
patched 1.16.0 instead of just the root install. Without this, the
GHSA-fvcv-3m26-pcqx prototype-pollution gadget remains loadable from
the nested install whenever the update check runs in production.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@denbec denbec merged commit 59fae26 into main May 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant