-
Notifications
You must be signed in to change notification settings - Fork 227
Publish /en/lessons/choropleth-maps-python-folium #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upload images directory
Upload original avatar
Upload gallery avatar.
Add bio for Adam Porter
Create Markdown file for new EN original lesson.
Update link, line 69.
Hello Alex @hawc2, I’ve staged choropleth-maps-python-folium for publication. You can read it through in Preview and let me know if you note anything which you'd like to adjust. We can publish this next week! Thank you. |
@anisa-hawes Looks good. A couple minor things:
"# counties = gpd.read_file("https://www2.census.gov/geo/tiger/GENZ2021/shp/cb_2021_us_county_5m.zip")" The paragraph before seems to suggest either code would work, it's a bit confusing. That's all I see, it otherwise looks great to me and ready to go! |
Correct typing error, line 85.
Thank you, Alex @hawc2. From what I can understand this line of code would extract data from a ZIP file hosted at a URL. As it uses the same structure as the line above, I don't think it serves to demonstrate an alternate working scenario. I have asked Adam about whether this is necessary to include, and will let you know what he advises. (I'll fix the broken links which are blocking this build too). |
Add sentence of explanation, line 178.
Hello again Alex @hawc2, I've been in touch with Adam, and now understand that the intention was to give a choice to readers of which lines of code to use, depending on whether they wish to work with the archived dataset or the up-to-date census data. In the previous section Getting the Fatal Force Data, this is made clear to readers. Adam agrees that we should add a similar sentence of explanation here:
I've made that addition: 87e5457 |
Awesome thanks @anisa-hawes, I'll approve the pull request |
Preparing files for publication.
Closes #3550
Checklist
Closes #ISSUENUMBER
to your summary above[ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.