Skip to content

Chore : workflow 수정#79

Merged
Lee9Bin merged 1 commit into
devfrom
chore/ci-cd
Jan 7, 2026
Merged

Chore : workflow 수정#79
Lee9Bin merged 1 commit into
devfrom
chore/ci-cd

Conversation

@Lee9Bin

@Lee9Bin Lee9Bin commented Jan 7, 2026

Copy link
Copy Markdown
Member
  • 환경변수 플레이스홀더 유지를 위해 작은따옴표 사용

Summary by CodeRabbit

  • Chores
    • Improved deployment workflow reliability by refining how application configuration is processed during the deployment process.

✏️ Tip: You can customize this high-level summary in your review settings.

- 환경변수 플레이스홀더 유지를 위해 작은따옴표 사용
@Lee9Bin Lee9Bin self-assigned this Jan 7, 2026
@coderabbitai

coderabbitai Bot commented Jan 7, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The deploy workflow's application.yml generation step changes from double quotes to single quotes when echoing the APPLICATION_PROPERTIES secret. Single quotes prevent shell interpretation, preserving the secret's literal content including newlines without expansion or escaping.

Changes

Cohort / File(s) Summary
Deploy workflow secret handling
.github/workflows/deploy.yml
Changed echo command from double quotes to single quotes when writing APPLICATION_PROPERTIES secret to application.yml, preventing unintended shell interpretation and preserving literal content

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A secret once quoted with double care,
Now wrapped in singles, beyond compare,
No shell shall expand what's meant to stay,
Newlines preserved, hooray, hooray! ✨


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 822b636 and 7e2aef7.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lee9Bin
Lee9Bin merged commit 3ca9642 into dev Jan 7, 2026
1 of 2 checks passed
@Lee9Bin
Lee9Bin deleted the chore/ci-cd branch January 7, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant