test: verify broker properties update reconciliation#829
Open
pavanvishnusai wants to merge 1 commit into
Open
Conversation
Signed-off-by: Pavan Vishnu Sai Bestha <pavanvishnusai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Strengthens the Agent reconciliation unit test for existing discovery requests.
Previously,
test_reconcile_nothing_to_doonly verified thatset_extra_device_properties()was called. This update verifies that the method receives the broker properties from the updatedConfigurationSpec.This helps cover the reconciliation path where an existing discovery request should receive updated broker properties from the Akri Configuration.
Special notes for your reviewer:
This is a test-only change. No production behavior is changed.
Testing:
rustfmt agent/src/util/discovery_configuration_controller.rs --edition 2021 --checkcargo test -p agent test_reconcile_nothing_to_do, but local macOS build is blocked by the Linux-onlylibudevsystem dependency.If applicable:
rustfmt agent/src/util/discovery_configuration_controller.rs --edition 2021 --check)cargo build)cargo clippy)cargo test)cargo doc)