Conversation
tsconn23
reviewed
Jul 15, 2021
| @@ -47,8 +53,18 @@ func NewSubscriber(nodeConfig *configfile.NodeConfig, subConfig *configfile.SubC | |||
| C.sub_receive_announce(sub.Subscriber, address) | |||
Contributor
There was a problem hiding this comment.
After incorporating changes and using the v1.1.0 .so that you and I built earlier this week, I am receiving the following error on this line.
{"timestamp":"2021-07-15T16:39:20Z","hostname":"ubuntu","application":"./alvarium-example","line-number":"publisher.go:198","log-level":"debug","message":"announcement response - { \"announcement_id\": \"32bc4e28380e08ed4923b515481b045a028662441e7f28c2da82d7b838cc784d0000000000000000:6936d4e499c982365578a582\" }"}
{"timestamp":"2021-07-15T16:39:20Z","hostname":"ubuntu","application":"./alvarium-example","line-number":"sdk.go:41","log-level":"error","message":"sub_receive_announce() returned error \nSTREAMS ERROR: Operation failed to execute properly"}
I notice in the PR there's no error checking here so I removed my error check to see if it would fall through and work but no luck.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the update showing the new function calls from the c bindings, showing how to manage the general error handling (all just logs for now). It also includes the updated
channels.h. I've tested it and it worked, but there were still problems with the latency, so we'll have to discuss options on that front.