Skip to content

Update subscriber for v1.1.0#22

Open
DyrellC wants to merge 1 commit intodevelopfrom
update-for-v1.1.0
Open

Update subscriber for v1.1.0#22
DyrellC wants to merge 1 commit intodevelopfrom
update-for-v1.1.0

Conversation

@DyrellC
Copy link
Copy Markdown
Collaborator

@DyrellC DyrellC commented Jul 14, 2021

Here's the update showing the new function calls from the c bindings, showing how to manage the general error handling (all just logs for now). It also includes the updated channels.h. I've tested it and it worked, but there were still problems with the latency, so we'll have to discuss options on that front.

@DyrellC DyrellC requested a review from tsconn23 July 14, 2021 15:53
Comment thread iota/Subscriber.go
@@ -47,8 +53,18 @@ func NewSubscriber(nodeConfig *configfile.NodeConfig, subConfig *configfile.SubC
C.sub_receive_announce(sub.Subscriber, address)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After incorporating changes and using the v1.1.0 .so that you and I built earlier this week, I am receiving the following error on this line.

{"timestamp":"2021-07-15T16:39:20Z","hostname":"ubuntu","application":"./alvarium-example","line-number":"publisher.go:198","log-level":"debug","message":"announcement response - { \"announcement_id\": \"32bc4e28380e08ed4923b515481b045a028662441e7f28c2da82d7b838cc784d0000000000000000:6936d4e499c982365578a582\" }"}
{"timestamp":"2021-07-15T16:39:20Z","hostname":"ubuntu","application":"./alvarium-example","line-number":"sdk.go:41","log-level":"error","message":"sub_receive_announce() returned error \nSTREAMS ERROR: Operation failed to execute properly"}

I notice in the PR there's no error checking here so I removed my error check to see if it would fall through and work but no luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants