Skip to content

Skip elements with provisional ancestors #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AryaHassanli merged 5 commits into from
Apr 7, 2026
+363 −0
Merged

Skip elements with provisional ancestors #59

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3810ac5
Skip elements with provisional ancestors
AryaHassanli Apr 7, 2026
7f4897a
Update ignoring logic
AryaHassanli Apr 7, 2026
d62b554
Fix ignoring logic for violations of type ViolationTypeNonProvisional
AryaHassanli Apr 7, 2026
ee0123e
test provisionality logic
AryaHassanli Apr 7, 2026
b6b0c0c
Remove redundant comment
AryaHassanli Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions provisional/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ func compare(specs spec.SpecPullRequest) (violationsByPath map[string][]spec.Vio
parent = parent.Parent()
}

// When an ancestor is provisional, we don't need to report violations for this entity
if parent != nil {
continue
}
Comment thread
AryaHassanli marked this conversation as resolved.
Outdated

v := spec.Violation{Entity: entity, Type: violationType}
v.Path, v.Line = entity.Origin()
violationsByPath[v.Path] = append(violationsByPath[v.Path], v)
Expand Down
Loading