Skip to content

[Camera] Add CameraAppTestSuite for Matter Camera TCs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: v2.13-develop
Choose a base branch
from
Open

[Camera] Add CameraAppTestSuite for Matter Camera TCs #214

wants to merge 7 commits into from

Conversation

chulspro
Copy link

Problem

  • For the Camera Controller
  • Add functionality to use camera-controller only for camera app test cases.
  • The test cases in FirstChipToolSuite are always executed with chip-tool.
  • The camera test cases should either run with camera-controller with the separate test suite within Yaml meant for camera test cases only.

Change overview

  • This PR adds a new Test Suite CameraAppTestSuite to test Matter Camera automated TCs only with chip-camera-controller.
  • The FirstChipToolSuite test suite in TH, which is used to run automated and semi-automated test cases, only runs the test cases using chip-tool.
  • Since the Camera/WebRTC TCs require chip-camera-controller to run the test cases, it cannot be clubbed with the existing FirstChipToolSuite(also TH allows running multiple test cases in suite at once). Hence a new test suite is required for Camera/WebRTC TCs alone.

Testing

  • Excute TestHarness and check WebRTC Requestor/Provider operations

s-gatti added 2 commits April 24, 2025 08:49
@chulspro
Add CameraAppTestSuite to run only camera test cases using camera-con…
519ff00 
…troller.

Signed-off-by: Sathvik K Gatti <[email protected]>
Signed-off-by: Suyambulingam Rathinasamy Muthupandi <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
@chulspro
Apply formatter and fix linter issues
30009f6 
Signed-off-by: Sathvik K Gatti <[email protected]>
Signed-off-by: Suyambulingam Rathinasamy Muthupandi <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
@chulspro chulspro mentioned this pull request Apr 23, 2025
Closed
@chulspro
Fix failing tests
4403e8a 
Signed-off-by: Sathvik K Gatti <[email protected]>
Signed-off-by: Suyambulingam Rathinasamy Muthupandi <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
@chulspro chulspro force-pushed the feature/contribution-certification-tool-backend-2 branch from c4aceb7 to 4403e8a Compare April 24, 2025 00:06
antonio-amjr
antonio-amjr requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@antonio-amjr antonio-amjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chulspro,

Found something in the code, please see the suggestion below:

s-gatti and others added 2 commits April 28, 2025 18:55
@chulspro
Copy link
Author

@antonio-amjr , @rquidute : I applied your comments in the patch. please review again. Thank you and appreciated your time.

@suyambulingamrm @chulspro
Fix review comments
4017340 
Adds new constant file for user action prompts.

Signed-off-by: suyambu.rm <[email protected]>
Signed-off-by: Charles Kim <[email protected]>
@suyambulingamrm @chulspro
Fix lint errors
5027149 
Signed-off-by: Charles Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rquidute rquidute rquidute approved these changes

@ccruzagralopes ccruzagralopes ccruzagralopes approved these changes

@antonio-amjr antonio-amjr antonio-amjr approved these changes

@hiltonlima hiltonlima Awaiting requested review from hiltonlima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chulspro @rquidute @ccruzagralopes @antonio-amjr @suyambulingamrm