Skip to content

Conversation

@chulspro
Copy link
Contributor

This PR adds enables the TH to mute/unmute the microphone when validating two-way talk back feature

@gemini-code-assist
Copy link

Summary of Changes

Hello @chulspro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the camera's two-way talk verification popup by adding microphone mute/unmute capabilities. This feature provides users with greater control over their audio input during validation sessions, improving the overall user experience and interaction with the system. The changes involve UI updates, state management, and integration with the underlying WebRTC service to manage audio tracks.

Highlights

  • Microphone Mute Functionality: Implemented the ability to mute and unmute the microphone within the two-way talk verification popup, giving users more control over their audio during validation.
  • User Interface Integration: A clickable microphone icon has been added to the popup modal. This icon visually changes to indicate whether the microphone is currently muted or unmuted, enhancing user feedback.
  • WebRTC Stream Control: The mute functionality is integrated with the WebRTC service, allowing direct control over the local audio stream by enabling or disabling its tracks based on the mute state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a mute/unmute functionality for the microphone in the two-way talk verification popup. The implementation is mostly solid, introducing a new UI element to control the microphone and the corresponding logic to toggle the audio track's enabled state. However, I've identified a logic issue that could cause the UI's mute status to become out of sync with the actual microphone state. I've also provided a suggestion to simplify the CSS for better clarity. With these adjustments, this will be a great feature.

Signed-off-by: Charles Kim <[email protected]>
@chulspro
Copy link
Contributor Author

@raul-marquez-csa , @gvargas-csa : Thank you for your time. Please review this PR for SVE. Thank you.

Copy link
Contributor

@raul-marquez-csa raul-marquez-csa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants