Check that we are on the Matter thread when we do ErrorStr. #25313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a single static buffer, so using it from multiple threads can race on writes to that buffer. In the worst case, we could end up with that buffer not null-terminated in a useful way.
|
PR #25313: Size comparison from ad5dc95 to 89a7ed9 Increases (26 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, esp32, k32w, linux, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, cc32xx, psoc6, telink)
Full report (46 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This stale pull request has been automatically closed. Thank you for your contributions. |
|
PR #25313: Size comparison from 40fb7c2 to 89a7ed9 Increases (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (14 builds for bl702, cc32xx, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Need to figure out how to proceed here, given the fact that we do in fact have thread-unsafe use of this buffer.... |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances thread safety in error message generation by verifying that ErrorStr is only called from the Matter thread.
- Inserts a runtime assertion in ErrorStr to enforce thread confinement.
- Updates include directives to add LockTracker support.
Files not reviewed (2)
- src/ble/tests/BUILD.gn: Language not supported
- src/lib/core/tests/BUILD.gn: Language not supported
Comments suppressed due to low confidence (1)
src/lib/support/ErrorStr.cpp:60
- Ensure that this assertion is effective in production builds; if assertions are disabled in release mode, consider adding a runtime check to prevent race conditions.
assertChipStackLockedByCurrentThread();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a single static buffer, so using it from multiple threads can race on writes to that buffer. In the worst case, we could end up with that buffer not null-terminated in a useful way.