-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM XMLs: Add parsing for data types [WIP] #37904
Draft
cecille
wants to merge
1
commit into
project-chip:master
Choose a base branch
from
cecille:field_parsing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that anything with a within-data-type conformance will have a conformance of optional currently. This is OK since we're not actually using these for anything expect understanding P markings currently. TODO: Still not parsing multi-bit bitfields correctly. TODO: Needs unit tests TODO: Probably not passing CI on the test support tests because of the new errors with the bitfields.
PR #37904: Size comparison from cfcfef3 to 989c28e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that anything with a within-data-type conformance will have a conformance of optional currently. This is OK since we're not actually using these for anything expect understanding P markings currently.
TODO: Still not parsing multi-bit bitfields correctly. TODO: Needs unit tests
TODO: Probably not passing CI on the test support tests
because of the new errors with the bitfields.
Testing
runs, but needs unit tests. Still WIP. Putting up before I go on vacation.