Skip to content

[1.4][Cherrypick] Add Mounted device types to v1.4-branch #38737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: v1.4-branch
Choose a base branch
from
Open

[1.4][Cherrypick] Add Mounted device types to v1.4-branch #38737

wants to merge 5 commits into from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented May 3, 2025 •
edited
Loading

Description

The 1.4 Matter version brings mounted device types (from Matter 1.4):

Fixes issue: #38718

Testing

The testing consisted of using the Zap tool to generate the example with a new device type.

@mergify mergify bot added the conflict label May 3, 2025
@lboue lboue changed the base branch from master to v1.4-branch May 3, 2025 08:41
@mergify mergify bot removed the conflict label May 3, 2025
@lboue lboue mentioned this pull request May 3, 2025
Open
@lboue lboue marked this pull request as ready for review May 3, 2025 09:31
@lboue lboue requested a review from a team as a code owner May 3, 2025 09:31
@lboue lboue changed the title [1.4][Cherrypick] Add Mounted device type (from Matter 1.4) [1.4][Cherrypick] Add Mounted device types (from Matter 1.4) May 3, 2025
@lboue
Copy link
Contributor Author

lboue commented May 3, 2025

Do you know why the Build on Darwin (clang, python_lib, simulated) CI job is failing on TCP transport error?

[1746267398.235] [82372:254392] [-] RETRYING tcp initialization
[1746267398.474] [82372:254392] [IN] Failed to initialize TCP transport: src/inet/TCPEndPointImplSockets.cpp:133: OS Error 0x02000030: Address already in use
src/transport/raw/tests/TestTCP.cpp:165: Failure
      Expected: err == CHIP_ERROR(0, "src/transport/raw/tests/TestTCP.cpp", 165)
        Actual: CHIP_ERROR:<src/inet/TCPEndPointImplSockets.cpp:133: OS Error 0x02000030: Address already in use> == CHIP_NO_ERROR
[1746267398.474] [82372:254392] [IN] TransportMgr initialized
src/transport/raw/tests/TestTCP.cpp:196: Failure
      Expected: err == CHIP_ERROR(0, "src/transport/raw/tests/TestTCP.cpp", 196)
        Actual: CHIP_ERROR:<src/transport/raw/TCP.cpp:205: Error 0x00000003> == CHIP_NO_ERROR
src/transport/raw/tests/TestTCP.cpp:199: Failure
      Expected: mReceiveHandlerCallCount == 1
        Actual: 0 == 1
src/transport/raw/tests/TestTCP.cpp:651: Failure
      Expected: state != nullptr
        Actual: (null) != (null)
[  FAILED  ] TestTCP.CheckProcessReceivedBuffer
[==========] Done running all tests.

@lboue lboue changed the title [1.4][Cherrypick] Add Mounted device types (from Matter 1.4) [1.4][Cherrypick] Add Mounted device types to v1.4-branch May 3, 2025
@lboue lboue mentioned this pull request May 7, 2025
Merged
@lboue
Copy link
Contributor Author

lboue commented May 7, 2025

Do you know why the Build on Darwin (clang, python_lib, simulated) CI job is failing on TCP transport error?

[1746267398.235] [82372:254392] [-] RETRYING tcp initialization
[1746267398.474] [82372:254392] [IN] Failed to initialize TCP transport: src/inet/TCPEndPointImplSockets.cpp:133: OS Error 0x02000030: Address already in use
src/transport/raw/tests/TestTCP.cpp:165: Failure
      Expected: err == CHIP_ERROR(0, "src/transport/raw/tests/TestTCP.cpp", 165)
        Actual: CHIP_ERROR:<src/inet/TCPEndPointImplSockets.cpp:133: OS Error 0x02000030: Address already in use> == CHIP_NO_ERROR
[1746267398.474] [82372:254392] [IN] TransportMgr initialized
src/transport/raw/tests/TestTCP.cpp:196: Failure
      Expected: err == CHIP_ERROR(0, "src/transport/raw/tests/TestTCP.cpp", 196)
        Actual: CHIP_ERROR:<src/transport/raw/TCP.cpp:205: Error 0x00000003> == CHIP_NO_ERROR
src/transport/raw/tests/TestTCP.cpp:199: Failure
      Expected: mReceiveHandlerCallCount == 1
        Actual: 0 == 1
src/transport/raw/tests/TestTCP.cpp:651: Failure
      Expected: state != nullptr
        Actual: (null) != (null)
[  FAILED  ] TestTCP.CheckProcessReceivedBuffer
[==========] Done running all tests.

Seems fixed by ba6168c

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

PR #38737: Size comparison from ba6168c to a579238

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ba6168c a579238 change % change
bl602 lighting-app bl602 FLASH 1281296 1281296 0 0.0
RAM 96040 96040 0 0.0
bl602+mfd FLASH 1309344 1309344 0 0.0
RAM 95696 95696 0 0.0
bl602+rpc FLASH 1335716 1335716 0 0.0
RAM 104016 104016 0 0.0
bl702 lighting-app bl702 FLASH 944914 944914 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957624 957624 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051328 1051328 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658334 658334 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824842 824842 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961850 961850 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974612 974612 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829408 829408 0 0.0
RAM 123484 123484 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814764 814764 0 0.0
RAM 125364 125364 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761272 761272 0 0.0
RAM 113864 113864 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745500 745500 0 0.0
RAM 114048 114048 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617226 617226 0 0.0
RAM 205948 205948 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657378 657378 0 0.0
RAM 206092 206092 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678317 678317 0 0.0
RAM 78700 78700 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81332 81332 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698169 698169 0 0.0
RAM 81332 81332 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655105 655105 0 0.0
RAM 73768 73768 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614725 614725 0 0.0
RAM 71668 71668 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634361 634361 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634361 634361 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634037 634037 0 0.0
RAM 74708 74708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653745 653745 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653745 653745 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609349 609349 0 0.0
RAM 68796 68796 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629201 629201 0 0.0
RAM 71428 71428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629201 629201 0 0.0
RAM 71428 71428 0 0.0
efr32 lighting-app BRD4187C FLASH 934116 934116 0 0.0
RAM 136280 136280 0 0.0
lock-app BRD2605a FLASH 741640 741616 -24 -0.0
RAM 232156 232156 0 0.0
BRD4338a FLASH 742080 742056 -24 -0.0
RAM 232040 232040 0 0.0
window-app BRD4187C FLASH 1017912 1017904 -8 -0.0
RAM 128212 128212 0 0.0
esp32 all-clusters-app c3devkit DRAM 95080 95080 0 0.0
FLASH 1541832 1541832 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116032 116032 0 0.0
FLASH 1552170 1552170 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781553 2781553 0 0.0
RAM 129680 129680 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6085700 6085700 0 0.0
RAM 510784 510784 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5418982 5418982 0 0.0
RAM 241424 241424 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4752432 4752432 0 0.0
RAM 218608 218608 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 12724946 12725002 56 0.0
RAM 561250 561250 0 0.0
chip-tool-ipv6only arm64 unknown 20792 20792 0 0.0
FLASH 11350240 11350368 128 0.0
RAM 611616 611616 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11022541 11022541 0 0.0
RAM 560138 560138 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575202 4575202 0 0.0
RAM 205240 205240 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692257 5692257 0 0.0
RAM 228648 228648 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801996 4801996 0 0.0
RAM 204696 204696 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4431416 4431416 0 0.0
RAM 198384 198384 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4570238 4570238 0 0.0
RAM 202952 202952 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3111693 3111693 0 0.0
RAM 159504 159504 0 0.0
thermostat-no-ble arm64 unknown 9464 9464 0 0.0
FLASH 4319536 4319536 0 0.0
RAM 243088 243088 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6043605 6043605 0 0.0
RAM 584416 584416 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10851773 10851869 96 0.0
RAM 649184 649184 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914272 914272 0 0.0
RAM 142387 142387 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885264 885264 0 0.0
RAM 140534 140534 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847676 847676 0 0.0
RAM 141281 141281 0 0.0
nxp contact k32w0+release FLASH 582104 582104 0 0.0
RAM 70976 70976 0 0.0
k32w1+release FLASH 596784 596784 0 0.0
RAM 63200 63200 0 0.0
mcxw71+release FLASH 596528 596528 0 0.0
RAM 63200 63200 0 0.0
light k32w0+release FLASH 618700 618700 0 0.0
RAM 70448 70448 0 0.0
k32w1+release FLASH 682808 682808 0 0.0
RAM 48832 48832 0 0.0
mcxw71+release FLASH 682808 682808 0 0.0
RAM 48832 48832 0 0.0
lock k32w1+release FLASH 705080 705080 0 0.0
RAM 67348 67348 0 0.0
mcxw71+release FLASH 705104 705104 0 0.0
RAM 67348 67348 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646460 1646460 0 0.0
RAM 211432 211432 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552540 1552540 0 0.0
RAM 208240 208240 0 0.0
light cy8ckit_062s2_43012 FLASH 1467996 1467996 0 0.0
RAM 201232 201232 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465052 1465052 0 0.0
RAM 225592 225592 0 0.0
qpg lighting-app qpg6105+debug FLASH 660480 660480 0 0.0
RAM 105428 105428 0 0.0
lock-app qpg6105+debug FLASH 618444 618444 0 0.0
RAM 99904 99904 0 0.0
stm32 light STM32WB5MM-DK FLASH 481760 481760 0 0.0
RAM 144876 144876 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620892 620892 0 0.0
RAM 50688 50688 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688104 688104 0 0.0
RAM 148528 148528 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781098 781098 0 0.0
RAM 110480 110480 0 0.0
bridge-app tlsr9258a FLASH 681004 681004 0 0.0
RAM 91344 91344 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620656 620656 0 0.0
RAM 50640 50640 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708610 708610 0 0.0
RAM 73980 73980 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625592 625592 0 0.0
RAM 144508 144508 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811364 811364 0 0.0
RAM 99140 99140 0 0.0
lock-app-dfu tlsr9528a FLASH 656574 656574 0 0.0
RAM 66700 66700 0 0.0
ota-requestor-app tlsr9258a FLASH 696976 696976 0 0.0
RAM 90936 90936 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634308 634308 0 0.0
RAM 55516 55516 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611498 611498 0 0.0
RAM 52760 52760 0 0.0
shell tlsr9518adk80d FLASH 467876 467876 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627812 627812 0 0.0
RAM 52352 52352 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653636 653636 0 0.0
RAM 56308 56308 0 0.0
thermostat tlsr9518adk80d FLASH 638224 638224 0 0.0
RAM 53152 53152 0 0.0
window-covering tlsr9118bdk40d FLASH 524360 524360 0 0.0
RAM 97484 97484 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1727096 1727096 0 0.0
RAM 89172 89172 0 0.0
chip-tool-ubsan arm unknown 10848 10848 0 0.0
FLASH 18024778 18024866 88 0.0
RAM 7870832 7870832 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app config controller darwin docker documentation Improvements or additions to documentation esp32 examples github icd Intermittently Connected Devices integrations lib linux messaging platform protocols scripts silabs support test driver tests tools transport vscode workflows
Projects
[Platform] Darwin
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lboue