[Silabs] Fixing the ipv4 build for the wifi devices #38830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38830: Size comparison from e1f80c6 to ae8e819 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #38830: Size comparison from b8d1181 to 717579b Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #38830: Size comparison from 8167c5f to 93eb861 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
May 12, 2025
|
PR #38830: Size comparison from 8167c5f to d87ac6f Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38830: Size comparison from ef66cd8 to d67de46 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
| { | ||
| WifiInterface::GetInstance().GotIPv4Address((uint32_t) sta_netif->ip_addr.u_addr.ip4.addr); | ||
| WifiInterfaceImpl::GetInstance().NotifyIPv4Change(false); |
There was a problem hiding this comment.
Why do we notify that we lost the IPv4 address before notifying that have one?
| @@ -30,6 +30,7 @@ | |||
| #include <lib/support/CHIPMemString.h> | |||
| #include <lib/support/CodeUtils.h> | |||
| #include <lib/support/logging/CHIPLogging.h> | |||
| #include <platform/silabs/wifi/WifiInterface.h> | |||
There was a problem hiding this comment.
This inlcude should not have any impact since it is available through the WifiInterfaceImpl header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
IPv4 build was failing for wifi devices
Fixing the build for the wifi devices
Tested soc and ncp builds and 917SoC and WF200 commissioning with IPv4