Handle change of DPTZRelativeMove -> DPTZStreams (list of int to list of struct) #38850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly handle setting of nightvision based on the HAL
Change DPTZRelativeMove attribute to DPTZStreams, which is now a struct that takes a viewport and a stream ID. Handle plumbing in the app to correctly set values based on stream allocation and deallocation.
…er/connectedhomeip into viewportupdatedhandling
|
PR #38850: Size comparison from 5107111 to 34fcf4e Full report (3 builds for cc32xx, stm32)
|
|
PR #38850: Size comparison from 5107111 to e7ecde3 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38850: Size comparison from 5107111 to 6feb936 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
May 12, 2025
|
PR #38850: Size comparison from 9b54b67 to f8f6281 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38850: Size comparison from 7e868e7 to da3a6b3 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…er/connectedhomeip into viewportupdatedhandling
|
PR #38850: Size comparison from 7e868e7 to 23f511c Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
saurabhst
approved these changes
May 16, 2025
pidarped
approved these changes
May 16, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
… of struct) (project-chip#38850) * XML update of CameraAVStreamManagement from Alchemy * Zap regen * Align with updated XML * Adding Push AV * Zap regen after adding PushAV * Restyled by whitespace * Restyled by clang-format * Restyled by prettier-json * Handle watermark in snapshot stream modify Correctly handle setting of nightvision based on the HAL * Restyled by whitespace * Restyled by clang-format * Revert optattr setting * Restyled by clang-format * Align with latest PR that makes enum values contiguous * Add regen code * Align with latest camera spec. Change DPTZRelativeMove attribute to DPTZStreams, which is now a struct that takes a viewport and a stream ID. Handle plumbing in the app to correctly set values based on stream allocation and deallocation. * Zap Regen after merge with master * Restyled by whitespace * Restyled by clang-format * Remove debug log * Zap formatting fixes * Add static cast * Remove inadvertant inclusions * Update AVSUM 2_1 to reflect the new attribute name and type * Zap changes --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy regen of XML based on spec update
Update server code and camera app code to handle new signatures and types
Update logic on stream allocation to reflect the stream and viewport in AVSettings
Testing
Rebuild chip-tool, camera-app, all-clusters-app
Re-run AVSUM 2.7 and 2.8
Unit test via chip tool attribute read, stream allocation, viewport updates, viewport move, stream deallocation