tv-casting-app/tv-app target app, commissioner passcode flow #38856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38856: Size comparison from a46f52c to 5776a4c Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #38856: Size comparison from a46f52c to 3e187d5 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
sharadb-amazon
approved these changes
May 10, 2025
|
PR #38856: Size comparison from 6876fcb to 5541705 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38856 +/- ##
===========================================
+ Coverage 57.26% 72.79% +15.53%
===========================================
Files 130 725 +595
Lines 12654 51238 +38584
===========================================
+ Hits 7246 37300 +30054
- Misses 5408 13938 +8530 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisdecenzo
approved these changes
May 12, 2025
Fixing tv-casting-app CI test
pgregorr-amazon
force-pushed
the
linux-targetApp-20250509
branch
from
5541705 to
75c3ab9
Compare
|
PR #38856: Size comparison from b7e1236 to 75c3ab9 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
hawk248
approved these changes
May 13, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using Vendor ID 1111 for the target content app when running the commissioner generated passcode commissioning flow. This was causing confusion among developers. The TV content app with Vendor ID 1111 does not allow list the client’s Vendor ID 65521 which is why, upon successful commissioning the tv-casting-app did not receive and was not able to interact with Endpoints with Vendor ID 1111. This also caused re-connection issues since Endpoints with Vendor ID 1111 were not cached.
Change Summary
Testing
Verified and tested locally with the Linux tv-casting-app (mobile app) and the Linux tv-app (CastingPlayer). Able to build and commission with the example app using both the commissionee and commissioner generated passcode flows. Able to re-establish connection with a CastingPlayer which has already been commissioned.