Code Review Rules

.pullapprove.yml

@@ -237,6 +237,100 @@ groups:
     reviews:
       request: 0 # Do not auto-add
 
+  ############################################################
+  #  Path specific review requirments. A PR must meet the
+  #  review requirements corresponding each path in the
+  #  in the CUSTOM_REVIEW_PATHS list that it touches. If it
+  #  touches a region not covered by any custom review paths, 
+  #  base condition is required.
+  ############################################################
+
+  ############################################################
+  #  Review requirements for PRs touching scripts/build*.
+  #  One shared-reviewers-scripts-build review is sufficient.
+  ############################################################
+  shared-reviewers-scripts-build:
+    type: required
+    conditions:
+      - files.include('scripts/build/*')
+    reviewers:
+      users:
+        - andy31415
+    requirements:
+      - "len(groups.approved.include('shared-reviewers-scripts-build')) >= 1 or \
+        len(groups.approved.include('shared-reviewers-*')) >= 2"
+    reviews:
+      # 1 review request will be sent at a time
+      request: 1
+      required: 0
+
+  ############################################################
+  #  Review requirements for PRs touching integrations/docker*
+  #  One shared-reviewers-integrations-docker review is
+  #  sufficient.
+  ############################################################
+  shared-reviewers-integrations-docker:
+    type: required
+    conditions:
+      - files.include('integrations/docker/*')
+    reviewers:
+      users:
+        - andy31415
+    requirements:
+      - "len(groups.approved.include('shared-reviewers-integrations-docker')) >= 1 or \
+        len(groups.approved.include('shared-reviewers-*')) >= 2"
+    reviews:
+      # 1 review request will be sent at a time
+      request: 1
+      required: 0
+
+  ############################################################
+  #  Review requirements for PRs touching examples/chef*
+  #  One Googler requirement is sufficient.
+  ############################################################
+  shared-reviewers-chef:
+    type: required
+    conditions:
+      - files.include('examples/chef/*')
+    requirements:
+      - "len(groups.approved.include('shared-reviewers-google')) >= 1 or \
+        len(groups.approved.include('shared-reviewers-*')) >= 2"
+    reviews:
+      required: 0
+
+  ############################################################
+  #  Review requirements for PRs touching integrations/cloudbuild*
+  #  One Google review is sufficient.
+  ############################################################
+  shared-reviewers-integrations-cloudbuild:
+    type: required
+    conditions:
+      - files.include('integrations/cloudbuild/*')
+    requirements:
+      - "len(groups.approved.include('shared-reviewers-google')) >= 1 or \
+        len(groups.approved.include('shared-reviewers-*')) >= 2"
+    reviews:
+      required: 0
+
+  ############################################################
+  #  Review requirements for PRs touching src/darwin
+  #  One Apple review is required.
+  ############################################################
+  shared-reviewers-src-darwin:
+    type: required
+    conditions:
+      - files.include('src/darwin/*')
+    reviewers:
+      users:
+        - bzbarsky
+    reviews:
+      request: 1
+      required: 1
+    labels:
+      approved: "[Darwin] review - approved"
+      pending: "[Darwin] review - pending"
+      rejected: "[Darwin] review - changed requested"
+
   ############################################################
   #  Base Required Reviewers
   ############################################################
@@ -247,6 +341,15 @@ groups:
       This is the main group of required reviews for general pull
       requests.
     type: required
+    conditions:
+      # If PR touches a region not covered by any custom review paths, base condition is required.
+      - "len(files\
+              .exclude('examples/chef/*')\
+              .exclude('scripts/build/*')\
+              .exclude('integrations/docker/*')\
+              .exclude('integrations/cloudbuild/*')\
+              .exclude('src/darwin/*')\
+            ) >= 1"
     requirements:
       - len(groups.approved.include('shared-reviewers-*')) >= 2
     reviews:

examples/chef/common/stubs.cpp

@@ -6,6 +6,10 @@
 #include <app/util/config.h>
 #include <lib/core/DataModelTypes.h>
 
+/**
+ * TODO: Remove this comment.
+ */
+
 using chip::app::DataModel::Nullable;
 
 using namespace chef;

integrations/cloudbuild/chef.yaml

@@ -89,3 +89,5 @@ artifacts:
 options:
     machineType: "E2_HIGHCPU_32"
     diskSizeGb: 500
+
+# TODO: Remove this comment.

integrations/docker/build.sh

@@ -121,3 +121,5 @@ if [ -f "$DOCKER_VOLUME_PATH" ]; then
 fi
 
 exit 0
+
+# TODO: Remove this comment.

scripts/build/BUILD.gn

@@ -72,3 +72,4 @@ pw_python_package("build_examples") {
     "build/test_target.py",
   ]
 }
+# TODO: Remove this comment.

src/darwin/Framework/CHIP/BUILD.gn

@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# TODO remove this comment.
+
 import("//build_overrides/chip.gni")
 
 config("darwin_config") {