Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,33 @@ groups:
reviews:
request: 0 # Do not auto-add

############################################################
# Path specific review requirments. A PR must meet the
# review requirements corresponding each path in the
# in the CUSTOM_REVIEW_PATHS list that it touches. If it
# touches a region not covered by any custom review paths,
# base condition is required.
############################################################
custom_review_paths: &CUSTOM_REVIEW_PATHS
- chef: &CHEF "examples/chef"

############################################################
# Review requirements for PRs touching examples/chef.
# One Googler requirement is sufficient.
############################################################
chef-required-reviewers:
type: required
conditions:
- any(f.startswith(*CHEF) for f in files)
requirements:
- len(groups.approved.include('shared-reviewers-google')) >= 1 or len(groups.approved.include('shared-reviewers-*')) >= 2
reviews:
required: 0
labels:
approved_chef: "review - approved: chef"
pending_chef: "review - pending: chef"
rejected_chef: "review - changed requested: chef"

############################################################
# Base Required Reviewers
############################################################
Expand All @@ -247,6 +274,9 @@ groups:
This is the main group of required reviews for general pull
requests.
type: required
conditions:
# If PR touches a region not covered by any custom review paths, base condition is required.
- not all(any(f.startswith(p) for p in *CUSTOM_REVIEW_PATHS) for f in files)
requirements:
- len(groups.approved.include('shared-reviewers-*')) >= 2
reviews:
Expand Down
Loading