Misc fixes for TC_EGC and TC_SEPR test cases #38893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38893: Size comparison from 57ca3b1 to 1b99cb8 Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
…doesn't support TCP we can still check basic read attribute with a forecast.
|
PR #38893: Size comparison from 57ca3b1 to 73c74e0 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
jamesharrow
changed the title
|
PR #38893: Size comparison from 57ca3b1 to 7ff6ea0 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
May 13, 2025
…StackError exception (not TimeoutError)
|
PR #38893: Size comparison from 57ca3b1 to f676c02 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
hasty
approved these changes
May 15, 2025
dsurnin
approved these changes
May 15, 2025
|
PR #38893: Size comparison from 01cb46e to 30f77c4 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 16, 2025
* Fixes project-chip#38892 - should have been lowercase .currentPrice * Improved TCP testing based on PICS "MCORE.SC.TCP" so that if the DUT doesn't support TCP we can still check basic read attribute with a forecast. * Fix missing 'TC' in 'desc_TC_EGC_2_1' etc (see project-chip/certification-tool#591) * Added missing 'TC' into all EGC scripts * Improved exception handling when failing to establish TCP we get ChipStackError exception (not TimeoutError) --------- Co-authored-by: Hasty Granbery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Tested as part of TE2 with ESP32 in docker container on test harness.
1st commission and run the test so that the device executes the TE trigger to set currentPrice attribute.
Run it again (without recommissioning or rebooting) - check that it gets past the crash on line 168 we saw previously.
Ran all EGC scripts against DUT to check no issues
Re-ran TC_SEPR_2_3 against DUT which does not support MCORE.SC.TCP and also with PICS arg to check it correctly asserts if PICS says it should support TCP. Also ran against Linux which does support TCP.
CI runs and passes