-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Generate GeneralCommissioning cluster with Alchemy #38970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tersal
wants to merge
5
commits into
project-chip:master
Choose a base branch
from
tersal:alchemy-general-commissioning-cluster-generation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Generate GeneralCommissioning cluster with Alchemy #38970
tersal
wants to merge
5
commits into
project-chip:master
from
tersal:alchemy-general-commissioning-cluster-generation
+2,751
−591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #38970: Size comparison from 2393eee to f4e59b4 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
May 15, 2025
src/app/zap-templates/zcl/data-model/chip/general-commissioning-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/general-commissioning-cluster.xml
Outdated
Show resolved
Hide resolved
PR #38970: Size comparison from a1323c6 to 8b3d388 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
PR #38970: Size comparison from a1323c6 to 5f33f7a Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/app/zap-templates/zcl/data-model/chip/general-commissioning-cluster.xml
Show resolved
Hide resolved
PR #38970: Size comparison from 9e7a682 to dab844b Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37391
Code generation for GeneralCommissioning cluster with Alchemy.
Since it was generated with the "in-progress" --attribute flag the attributes
RecoveryIdentifier
andNetworkRecoveryReason
were added along with theNetworkRecoveryReasonEnum
enum.Testing
UnitTests passing, example app compiling (all-clusters) and CI checks for compatibility.