Skip to content

fix: aggregate types should not have user-declared constructors #39060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: aggregate types should not have user-declared constructors #39060

wants to merge 1 commit into from
+0 −5

Conversation

j0tunn
Copy link
Contributor

@j0tunn j0tunn commented May 19, 2025

Prior to C++11 and since C++20 aggregate types should not have user-declared constructors: https://en.cppreference.com/w/cpp/language/aggregate_initialization#Designated_initializers

With user-declared constructors aggregate initialization will not compile for such types. And we will get compile errors like:

In file included from src/platform/Darwin/MdnsError.cpp:18:
src/platform/Darwin/DnssdImpl.h:284:59: error: no matching constructor for initialization of 'ResolveContextWithType'
  284 |     ResolveContextWithType resolveContextWithSRPType    = { this, true };
      |                                                           ^~~~~~~~~~~~~~
src/platform/Darwin/DnssdImpl.h:261:8: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
  261 | struct ResolveContextWithType
      |        ^~~~~~~~~~~~~~~~~~~~~~
src/platform/Darwin/DnssdImpl.h:263:5: note: candidate constructor not viable: requires 0 arguments, but 2 were provided
  263 |     ResolveContextWithType()  = delete;
      |     ^

Testing

Build on OSX with cpp_standard="c++20"

@j0tunn j0tunn requested a review from a team as a code owner May 19, 2025 10:17
@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2025 •
edited
Loading

PR #39060: Size comparison from ef66cd8 to cb1ca14

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section ef66cd8 cb1ca14 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103246 1103246 0 0.0
RAM 179082 179082 0 0.0
bl702 lighting-app bl702+eth FLASH 656476 656476 0 0.0
RAM 135041 135041 0 0.0
bl702+wifi FLASH 833986 833986 0 0.0
RAM 124597 124597 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066526 1066526 0 0.0
RAM 117429 117429 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895462 895462 0 0.0
RAM 105732 105732 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979550 979550 0 0.0
RAM 109932 109932 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 821700 821700 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 831560 831560 0 0.0
RAM 125448 125448 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 779120 779120 0 0.0
RAM 113844 113844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 763332 763332 0 0.0
RAM 114060 114060 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549574 549574 0 0.0
RAM 205264 205264 0 0.0
lock CC3235SF_LAUNCHXL FLASH 580982 580982 0 0.0
RAM 205456 205456 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662829 662829 0 0.0
RAM 77308 77308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682681 682681 0 0.0
RAM 79948 79948 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682681 682681 0 0.0
RAM 79948 79948 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639613 639613 0 0.0
RAM 72376 72376 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623981 623981 0 0.0
RAM 73604 73604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643609 643609 0 0.0
RAM 76156 76156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643609 643609 0 0.0
RAM 76156 76156 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 643325 643325 0 0.0
RAM 76604 76604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 663041 663041 0 0.0
RAM 79156 79156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 663041 663041 0 0.0
RAM 79156 79156 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619505 619505 0 0.0
RAM 70708 70708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 73340 73340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639357 639357 0 0.0
RAM 73340 73340 0 0.0
efr32 lock-app BRD4187C FLASH 946084 946084 0 0.0
RAM 132096 132096 0 0.0
BRD4338a FLASH 772912 772912 0 0.0
RAM 173320 173320 0 0.0
window-app BRD4187C FLASH 1038736 1038728 -8 -0.0
RAM 128232 128232 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1809664 1809664 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 122028 122028 0 0.0
FLASH 1775586 1775586 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2793796 2793796 0 0.0
RAM 115288 115288 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6369678 6369678 0 0.0
RAM 534008 534008 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5462406 5462406 0 0.0
RAM 225624 225624 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4770570 4770570 0 0.0
RAM 205008 205008 0 0.0
camera-app debug unknown 8864 8864 0 0.0
FLASH 6906651 6906651 0 0.0
RAM 226712 226712 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14406971 14406971 0 0.0
RAM 662096 662096 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14693091 14693091 0 0.0
RAM 648832 648832 0 0.0
chip-tool-ipv6only arm64 unknown 40352 40352 0 0.0
FLASH 12641392 12641392 0 0.0
RAM 695144 695144 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12766107 12766107 0 0.0
RAM 648192 648192 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4587172 4587172 0 0.0
RAM 191088 191088 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5733381 5733381 0 0.0
RAM 487328 487328 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5650881 5650881 0 0.0
RAM 207576 207576 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4824260 4824260 0 0.0
RAM 194872 194872 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4446070 4446070 0 0.0
RAM 184176 184176 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4575674 4575674 0 0.0
RAM 188080 188080 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3095164 3095164 0 0.0
RAM 148648 148648 0 0.0
thermostat-no-ble arm64 unknown 9624 9624 0 0.0
FLASH 4234000 4234000 0 0.0
RAM 231264 231264 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6092165 6092165 0 0.0
RAM 611800 611800 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12892733 12892733 0 0.0
RAM 769728 769728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 921508 921508 0 0.0
RAM 167398 167398 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 913256 913256 0 0.0
RAM 145642 145642 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858616 858616 0 0.0
RAM 141161 141161 0 0.0
nxp contact k32w0+release FLASH 592880 592880 0 0.0
RAM 72928 72928 0 0.0
mcxw71+release FLASH 625752 625752 0 0.0
RAM 63268 63268 0 0.0
light k32w0+release FLASH 619020 619020 0 0.0
RAM 72224 72224 0 0.0
k32w1+release FLASH 710480 710480 0 0.0
RAM 72116 72116 0 0.0
lock mcxw71+release FLASH 775560 775560 0 0.0
RAM 67692 67692 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1669172 1669172 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1573284 1573284 0 0.0
RAM 208592 208592 0 0.0
light cy8ckit_062s2_43012 FLASH 1447468 1447468 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1477364 1477364 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 668252 668252 0 0.0
RAM 105244 105244 0 0.0
lock-app qpg6105+debug FLASH 626448 626448 0 0.0
RAM 99872 99872 0 0.0
stm32 light STM32WB5MM-DK FLASH 465940 465940 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 694572 694572 0 0.0
RAM 101908 101908 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 774282 774282 0 0.0
RAM 50060 50060 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 781388 781388 0 0.0
RAM 109232 109232 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 703534 703534 0 0.0
RAM 62624 62624 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741488 741488 0 0.0
RAM 85796 85796 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 607710 607710 0 0.0
RAM 119448 119448 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 816698 816702 4 0.0
RAM 107500 107500 0 0.0
tizen all-clusters-app arm unknown 5224 5224 0 0.0
FLASH 1822424 1822424 0 0.0
RAM 95164 95164 0 0.0
chip-tool-ubsan arm unknown 20612 20612 0 0.0
FLASH 20922062 20922062 0 0.0
RAM 9096248 9096248 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

Assignees
No one assigned
Labels
darwin platform
Projects
[Platform] Darwin
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j0tunn @bzbarsky-apple