Define new JF server variables for JF Admins only #39095
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+69
to
+68
| "JointFabricDatastore.cpp", | ||
| "JointFabricDatastore.h", |
There was a problem hiding this comment.
Don't these need to get removed from the unconditional list above?
There was a problem hiding this comment.
Are these indepenent enough to be placed in a separate source_set and have a deps dependency so we can enforce #include logic? Would probably require a //nogncheck comment on the include that is guarded by ifdefs, however that seems desirable to enforce header dependency by GN.
There was a problem hiding this comment.
The changes have been moved under chip_device_config_enable_joint_fabric flag
There was a problem hiding this comment.
I see #38842 got through without unit testing.
Please apply these changes:
- use a source_set for these 2 files (so it can be referenced individually)
- add unit tests in a src/app/server/tests . Reference the source set so you can write the unit test
|
PR #39095: Size comparison from b996746 to f5f14f9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39095: Size comparison from 08eb175 to f6ec315 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 21, 2025
github-actions
bot
added
documentation
|
PR #39095: Size comparison from 05e766b to 0def7e7 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
doru91
reviewed
May 27, 2025
| @@ -120,6 +120,11 @@ declare_args() { | |||
| } | |||
| } | |||
|
|
|||
| declare_args() { | |||
| # Enable Joint Fabric features | |||
| chip_device_config_enable_joint_fabric = false | |||
There was a problem hiding this comment.
I had to introduce this in context of #38749 - which has been merged, Need to rebase this PR on latest master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new server variables introduced in PR #38842 are only needed for JF admins and should not be exposed to all devices.
Addresses #39093
Testing
Verify if the server variables are available only if for JF Admins