Enforce const correctness for deserialization in TableEntryData #39112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarcosb
force-pushed
the
table-updates
branch
2 times, most recently
from
c82416f to
510713a
Compare
bzbarsky-apple
approved these changes
May 21, 2025
tcarmelveilleux
approved these changes
May 21, 2025
|
PR #39112: Size comparison from 7c1536e to 510713a Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
gmarcosb
force-pushed
the
table-updates
branch
2 times, most recently
from
f35d098 to
85e02bd
Compare
|
PR #39112: Size comparison from 24069af to 85e02bd Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
May 21, 2025
|
PR #39112: Size comparison from 08eb175 to fb41856 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #38846 (comment)
Because
TableEntryDataextendsDataAccessor& overridesSerialize&Deserialize, it's difficult to split apart the mutable funcitonality (Deserialize) from the immutable parts (Serialize)A
ConstCorrectRefhelper which propagates const tomEntryprevents us from accidentally mutating, as the original code intended (C++ fields which are refs/pointers are not pointers to a constant)Testing
CI