Skip to content

[Network.framework] Move UDPEndPointImplNetworkFramework files under src/platform/Darwin/inet #39148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Network.framework] Move UDPEndPointImplNetworkFramework files under src/platform/Darwin/inet #39148

wants to merge 2 commits into from
+121 −63

Conversation

vivien-apple
Copy link
Contributor

Description

This PR moves the UDPEndPointImplNetworkFramework* implementation files under src/platform/Darwin` to better reflect their platform-specific scope.

Testing

No functional changes — only file relocations and build system updates.

@vivien-apple vivien-apple self-assigned this May 23, 2025
@vivien-apple vivien-apple requested a review from a team as a code owner May 23, 2025 08:33
@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2025 •
edited
Loading

PR #39148: Size comparison from f8f3c49 to dfbd430

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f8f3c49 dfbd430 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102242 1102242 0 0.0
RAM 179114 179114 0 0.0
bl702 lighting-app bl702+eth FLASH 655348 655348 0 0.0
RAM 135073 135073 0 0.0
bl702+wifi FLASH 832858 832858 0 0.0
RAM 124637 124637 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065398 1065398 0 0.0
RAM 117461 117461 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894952 894952 0 0.0
RAM 105772 105772 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978678 978678 0 0.0
RAM 109956 109956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820588 820588 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 832176 832176 0 0.0
RAM 125440 125440 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 777680 777680 0 0.0
RAM 113844 113844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 761996 761996 0 0.0
RAM 114052 114052 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548254 548254 0 0.0
RAM 205256 205256 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581694 581694 0 0.0
RAM 205448 205448 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661677 661677 0 0.0
RAM 77292 77292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681521 681521 0 0.0
RAM 79932 79932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681521 681521 0 0.0
RAM 79932 79932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638461 638461 0 0.0
RAM 72360 72360 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623061 623061 0 0.0
RAM 73604 73604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 642705 642705 0 0.0
RAM 76156 76156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 642705 642705 0 0.0
RAM 76156 76156 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76604 76604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 663705 663705 0 0.0
RAM 79156 79156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 663705 663705 0 0.0
RAM 79156 79156 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618665 618665 0 0.0
RAM 70716 70716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638517 638517 0 0.0
RAM 73348 73348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638517 638517 0 0.0
RAM 73348 73348 0 0.0
efr32 lock-app BRD4187C FLASH 946772 946772 0 0.0
RAM 132092 132092 0 0.0
BRD4338a FLASH 775728 775728 0 0.0
RAM 173320 173320 0 0.0
window-app BRD4187C FLASH 1039456 1039448 -8 -0.0
RAM 128228 128228 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1809024 1809024 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 122004 122004 0 0.0
FLASH 1774446 1774446 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2775690 2775690 0 0.0
RAM 115960 115960 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6365350 6365350 0 0.0
RAM 535512 535512 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5455156 5455156 0 0.0
RAM 226872 226872 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4790088 4790088 0 0.0
RAM 206528 206528 0 0.0
camera-app debug unknown 8864 8864 0 0.0
FLASH 6899003 6899003 0 0.0
RAM 227800 227800 0 0.0
camera-controller debug unknown 9104 9104 0 0.0
FLASH 14226315 14226315 0 0.0
RAM 656104 656104 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14619003 14619003 0 0.0
RAM 649872 649872 0 0.0
chip-tool-ipv6only arm64 unknown 40392 40392 0 0.0
FLASH 12594256 12594256 0 0.0
RAM 696216 696216 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12691997 12691997 0 0.0
RAM 649232 649232 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4576002 4576002 0 0.0
RAM 192208 192208 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5716373 5716373 0 0.0
RAM 488688 488688 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5637889 5637889 0 0.0
RAM 208696 208696 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4823872 4823872 0 0.0
RAM 196008 196008 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4427960 4427960 0 0.0
RAM 184832 184832 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4555340 4555340 0 0.0
RAM 188768 188768 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3080060 3080060 0 0.0
RAM 149864 149864 0 0.0
thermostat-no-ble arm64 unknown 9744 9744 0 0.0
FLASH 4226944 4226944 0 0.0
RAM 232360 232360 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6082501 6082501 0 0.0
RAM 612984 612984 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12816621 12816621 0 0.0
RAM 771392 771392 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 921652 921652 0 0.0
RAM 167396 167396 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 912904 912904 0 0.0
RAM 145640 145640 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858944 858944 0 0.0
RAM 141159 141159 0 0.0
nxp contact k32w0+release FLASH 592256 592256 0 0.0
RAM 72920 72920 0 0.0
mcxw71+release FLASH 625056 625056 0 0.0
RAM 63260 63260 0 0.0
light k32w0+release FLASH 618316 618316 0 0.0
RAM 72216 72216 0 0.0
k32w1+release FLASH 709568 709568 0 0.0
RAM 72116 72116 0 0.0
lock mcxw71+release FLASH 776192 776192 0 0.0
RAM 67676 67676 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1670612 1670612 0 0.0
RAM 212392 212392 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1575148 1575148 0 0.0
RAM 208576 208576 0 0.0
light cy8ckit_062s2_43012 FLASH 1448108 1448108 0 0.0
RAM 197304 197304 0 0.0
lock cy8ckit_062s2_43012 FLASH 1480324 1480324 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667228 667228 0 0.0
RAM 105244 105244 0 0.0
lock-app qpg6105+debug FLASH 627248 627248 0 0.0
RAM 99872 99872 0 0.0
stm32 light STM32WB5MM-DK FLASH 464964 464964 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 693732 676976 -16756 -2.4
RAM 101904 90764 -11140 -10.9
light-app-ota-compress-lzma-factory-data tl3218x FLASH 773160 773160 0 0.0
RAM 50056 50056 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770254 770254 0 0.0
RAM 40348 40348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 780266 758710 -21556 -2.8
RAM 109228 97476 -11752 -10.8
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 702600 686702 -15898 -2.3
RAM 62616 51584 -11032 -17.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 740554 715152 -25402 -3.4
RAM 85788 73396 -12392 -14.4
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 712492 712492 0 0.0
RAM 37032 37032 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 607112 607046 -66 -0.0
RAM 120000 106724 -13276 -11.1
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815576 793764 -21812 -2.7
RAM 107496 96324 -11172 -10.4
tizen all-clusters-app arm unknown 5280 5280 0 0.0
FLASH 1811352 1811352 0 0.0
RAM 95736 95736 0 0.0
chip-tool-ubsan arm unknown 20628 20628 0 0.0
FLASH 20869430 20869430 0 0.0
RAM 9081364 9081364 0 0.0

andy31415
andy31415 reviewed May 23, 2025
View reviewed changes
@vivien-apple vivien-apple force-pushed the NetworkFramework_MoveFilesUnderSrcPlatformDarwin branch from dfbd430 to be4b0d5 Compare May 24, 2025 09:37
@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2025 •
edited
Loading

PR #39148: Size comparison from a9afc79 to be4b0d5

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section a9afc79 be4b0d5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102242 1102242 0 0.0
RAM 179114 179114 0 0.0
bl702 lighting-app bl702+eth FLASH 655348 655348 0 0.0
RAM 135073 135073 0 0.0
bl702+wifi FLASH 832858 832858 0 0.0
RAM 124637 124637 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065398 1065398 0 0.0
RAM 117461 117461 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894952 894952 0 0.0
RAM 105772 105772 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978678 978678 0 0.0
RAM 109956 109956 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820588 820588 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 832176 832176 0 0.0
RAM 125440 125440 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 777680 777680 0 0.0
RAM 113844 113844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 761996 761996 0 0.0
RAM 114052 114052 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548254 548254 0 0.0
RAM 205256 205256 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581694 581694 0 0.0
RAM 205448 205448 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662253 662253 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682105 682105 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682105 682105 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639045 639045 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623645 623645 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643281 643281 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643281 643281 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644573 644573 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 664281 664281 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 664281 664281 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619241 619241 0 0.0
RAM 70896 70896 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639093 639093 0 0.0
RAM 73528 73528 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639093 639093 0 0.0
RAM 73528 73528 0 0.0
efr32 lock-app BRD4187C FLASH 946772 946772 0 0.0
RAM 132092 132092 0 0.0
BRD4338a FLASH 775728 775728 0 0.0
RAM 173320 173320 0 0.0
window-app BRD4187C FLASH 1039456 1039448 -8 -0.0
RAM 128228 128228 0 0.0
esp32 all-clusters-app c3devkit DRAM 103536 103536 0 0.0
FLASH 1809048 1809048 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 122316 122316 0 0.0
FLASH 1775058 1775058 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4760 4760 0 0.0
FLASH 2715576 2715576 0 0.0
RAM 115024 115024 0 0.0
all-clusters-app debug unknown 5600 5600 0 0.0
FLASH 6307370 6307370 0 0.0
RAM 535376 535376 0 0.0
all-clusters-minimal-app debug unknown 5464 5464 0 0.0
FLASH 5397032 5397032 0 0.0
RAM 225968 225968 0 0.0
bridge-app debug unknown 5496 5496 0 0.0
FLASH 4732894 4732894 0 0.0
RAM 205624 205624 0 0.0
camera-app debug unknown 8824 8824 0 0.0
FLASH 6840891 6840891 0 0.0
RAM 226864 226864 0 0.0
camera-controller debug unknown 9112 9112 0 0.0
FLASH 14229435 14229435 0 0.0
RAM 656584 656584 0 0.0
chip-tool debug unknown 6112 6112 0 0.0
FLASH 14592601 14592601 0 0.0
RAM 653920 653920 0 0.0
chip-tool-ipv6only arm64 unknown 40856 40856 0 0.0
FLASH 12569640 12569640 0 0.0
RAM 700944 700944 0 0.0
fabric-admin debug unknown 5800 5800 0 0.0
FLASH 12674067 12674067 0 0.0
RAM 653704 653704 0 0.0
fabric-bridge-app debug unknown 4736 4736 0 0.0
FLASH 4517874 4517874 0 0.0
RAM 191304 191304 0 0.0
fabric-sync debug unknown 4984 4984 0 0.0
FLASH 5639669 5639669 0 0.0
RAM 487400 487400 0 0.0
lighting-app debug+rpc+ui unknown 6208 6208 0 0.0
FLASH 5579809 5579809 0 0.0
RAM 207760 207760 0 0.0
lock-app debug unknown 5432 5432 0 0.0
FLASH 4765736 4765736 0 0.0
RAM 195072 195072 0 0.0
ota-provider-app debug unknown 4776 4776 0 0.0
FLASH 4369956 4369956 0 0.0
RAM 183928 183928 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4497390 4497390 0 0.0
RAM 187864 187864 0 0.0
shell debug unknown 4240 4240 0 0.0
FLASH 3033244 3033244 0 0.0
RAM 149600 149600 0 0.0
thermostat-no-ble arm64 unknown 9648 9648 0 0.0
FLASH 4177840 4177840 0 0.0
RAM 231184 231184 0 0.0
tv-app debug unknown 5760 5760 0 0.0
FLASH 6006741 6006741 0 0.0
RAM 611600 611600 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 1272866 1272866 0 0.0
RAM 764992 764992 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 921652 921652 0 0.0
RAM 167524 167524 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 912904 912904 0 0.0
RAM 145768 145768 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858944 858944 0 0.0
RAM 141159 141159 0 0.0
nxp contact k32w0+release FLASH 592256 592256 0 0.0
RAM 72920 72920 0 0.0
mcxw71+release FLASH 625056 625056 0 0.0
RAM 63260 63260 0 0.0
light k32w0+release FLASH 618316 618316 0 0.0
RAM 72216 72216 0 0.0
k32w1+release FLASH 709568 709568 0 0.0
RAM 72116 72116 0 0.0
lock mcxw71+release FLASH 776192 776192 0 0.0
RAM 67676 67676 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1670612 1670612 0 0.0
RAM 212520 212520 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1575148 1575148 0 0.0
RAM 208576 208576 0 0.0
light cy8ckit_062s2_43012 FLASH 1448108 1448108 0 0.0
RAM 197304 197304 0 0.0
lock cy8ckit_062s2_43012 FLASH 1480324 1480324 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 667228 667228 0 0.0
RAM 105244 105244 0 0.0
lock-app qpg6105+debug FLASH 627248 627248 0 0.0
RAM 99872 99872 0 0.0
stm32 light STM32WB5MM-DK FLASH 464964 464964 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 677220 677220 0 0.0
693976 693976 0 0.0
RAM 90944 90944 0 0.0
102084 102084 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 773404 773404 0 0.0
RAM 50236 50236 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770498 770498 0 0.0
RAM 40528 40528 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 758954 758954 0 0.0
780510 780510 0 0.0
RAM 97656 97656 0 0.0
109408 109408 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 686946 686946 0 0.0
702844 702844 0 0.0
RAM 51764 51764 0 0.0
62796 62796 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 715396 715396 0 0.0
740798 740798 0 0.0
RAM 73576 73576 0 0.0
85968 85968 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 712736 712736 0 0.0
RAM 37212 37212 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 607290 607290 0 0.0
607356 607356 0 0.0
RAM 106904 106904 0 0.0
120180 120180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 794004 794008 4 0.0
815820 815824 4 0.0
RAM 96504 96504 0 0.0
107676 107676 0 0.0
tizen all-clusters-app arm unknown 5280 5280 0 0.0
FLASH 1812176 1812176 0 0.0
RAM 96604 96604 0 0.0
chip-tool-ubsan arm unknown 20796 20796 0 0.0
FLASH 21014886 21014886 0 0.0
RAM 9155628 9155628 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

Assignees

@vivien-apple vivien-apple

Labels
darwin inet platform review - pending
Projects
[Platform] Darwin
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivien-apple @andy31415