[Linux/Tizen] Replace g_free usages with GAutoPtr #39151
+19
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #39151: Size comparison from 4ecc3de to d46f373 Full report (3 builds for cc32xx, stm32)
|
|
PR #39151: Size comparison from 4ecc3de to 431a0d2 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
May 23, 2025
|
@XToripuru it seems Tizen builds are unhappy: |
|
PR #39151: Size comparison from 4ecc3de to 749c579 Increases above 0.2%:
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
arkq
approved these changes
May 27, 2025
| { | ||
| g_free(mResultTxtRecord); | ||
| } | ||
| ResolveContext::~ResolveContext() = default; |
There was a problem hiding this comment.
Please, move it to the header file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code uses
g_freeto manually manage memory when RAII alternative would work just fine in that situation.Solution
Replace some
g_freeusages withGAutoPtr.T*is now accessed via.get().T**is now accessed via.out()..reset().Testing
Performing all tests (unit and integration) results in success