Add PushAV Test script for persistence of CurrentConnections attribute.#43172
Open
pidarped wants to merge 4 commits into
Open
Add PushAV Test script for persistence of CurrentConnections attribute.#43172pidarped wants to merge 4 commits into
pidarped wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request introduces a new test script, TC_PAVST_2_14.py, to validate the persistence of the CurrentConnections attribute in the PushAVTransport cluster across device reboots. The test logic correctly covers allocation, reboot verification, deallocation, and subsequent reboot verification. However, there are several implementation issues in the Python script, specifically regarding incorrect handling of return values from helper functions and redundant attribute reads that should be addressed to ensure the test runs correctly and efficiently.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Matter Python test case (TC_PAVST_2_14) to validate that the PushAV Stream Transport cluster’s CurrentConnections attribute persists across DUT reboots (and is cleared appropriately after deallocation).
Changes:
- Introduces
TC_PAVST_2_14test script covering allocate → reboot → verify persistence, then deallocate → reboot → verify cleared state. - Adds CI runner argument block for executing the test with the camera app.
|
PR #43172: Size comparison from 214f2d7 to 91dcd45 Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
pidarped
force-pushed
the
PushAVPersistenceTest
branch
from
c5c29e4 to
5ce6828
Compare
|
PR #43172: Size comparison from 214f2d7 to 5ce6828 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
pidarped
force-pushed
the
PushAVPersistenceTest
branch
from
cf72cc0 to
45e1723
Compare
|
PR #43172: Size comparison from 1be2abb to 45e1723 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
pidarped
force-pushed
the
PushAVPersistenceTest
branch
from
45e1723 to
84bc20e
Compare
|
PR #43172: Size comparison from 1be2abb to 84bc20e Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
chulspro
approved these changes
Feb 20, 2026
pidarped
force-pushed
the
PushAVPersistenceTest
branch
from
84bc20e to
01d7b8e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43172 +/- ##
==========================================
- Coverage 54.89% 54.88% -0.01%
==========================================
Files 1619 1619
Lines 110385 110411 +26
Branches 13484 13494 +10
==========================================
+ Hits 60597 60604 +7
- Misses 49788 49807 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43172: Size comparison from d93b463 to 01d7b8e Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
|
PR #43172: Size comparison from d93b463 to e3a09cd Full report (34 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Comment on lines
+138
to
+140
| current_connections = await self.read_pavst_attribute_expect_success(endpoint, pavst_attributes.CurrentConnections) | ||
| asserts.assert_equal(len(current_connections), 1, "CurrentConnections list should have 1 entry after reboot") | ||
| asserts.assert_equal(current_connections[0].connectionID, aConnectionID, "ConnectionID does not match after reboot") |
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pidarped
force-pushed
the
PushAVPersistenceTest
branch
from
cf104bf to
92411d5
Compare
|
PR #43172: Size comparison from 0844858 to 92411d5 Full report (33 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add TC_PAVST_2_14 as a persistence test for CurrentConnections attribute in PushAVTransport cluster.
Testing
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines